Issue 3035050: base: rename Environment::HasEnv to Environment::HasVar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3035050: base: rename Environment::HasEnv to Environment::HasVar. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Paweł Hajdan Jr.

CC:
chromium-reviews, pam+watch_chromium.org, fbarchard, Alpha Left Google, ben+cc_chromium.org, Paul Godavari, dpranke+watch_chromium.org, darin-cc_chromium.org, awong, Paweł Hajdan Jr., brettw-cc_chromium.org, scherkus (not reviewing)

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

base: rename Environment::HasEnv to Environment::HasVar. This is the part 2 of this series. More two comming. Splitting this into small parts, so it is more easy to review and reduce the size of the CL. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54996

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -21 lines)			Patch
M	base/environment.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/environment.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/environment_unittest.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	base/nss_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/xdg_util.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/audio_renderer_host_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/protocol_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/logging_chrome.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/process_watcher_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_tests.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui/ui_test_suite.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/audio/audio_output_controller_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages