Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 3035024: Increase HTTP request timeout to make dev server happy. (Closed)

Created:
10 years, 5 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Increase HTTP request timeout to make dev server happy. BUG=none TEST=unit tested, gmerged and tested with dev server

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M libcurl_http_fetcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
10 years, 5 months ago (2010-07-23 20:49:26 UTC) #1
adlr
10 years, 5 months ago (2010-07-23 21:17:37 UTC) #2
LGTM

On Fri, Jul 23, 2010 at 1:49 PM, <petkov@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> Increase HTTP request timeout to make dev server happy.
>
> BUG=none
> TEST=unit tested, gmerged and tested with dev server
>
> Please review this at http://codereview.chromium.org/3035024/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git
>
> Affected files:
>  M libcurl_http_fetcher.cc
>
>
> Index: libcurl_http_fetcher.cc
> diff --git a/libcurl_http_fetcher.cc b/libcurl_http_fetcher.cc
> index
>
12b11a005206dc9ec7a2690067f0dbb47eef3b56..3ae5fbfe4c7dd5f0ad87d7afcc96cc2bc4b68cac
> 100644
> --- a/libcurl_http_fetcher.cc
> +++ b/libcurl_http_fetcher.cc
> @@ -55,10 +55,10 @@ void LibcurlHttpFetcher::ResumeTransfer(const
> std::string& url) {
>                             StaticLibcurlWrite), CURLE_OK);
>   CHECK_EQ(curl_easy_setopt(curl_handle_, CURLOPT_URL, url_.c_str()),
> CURLE_OK);
>
> -  // If the connection drops under 10 bytes/sec for 90 seconds, reconnect.
> +  // If the connection drops under 10 bytes/sec for 3 minutes, reconnect.
>   CHECK_EQ(curl_easy_setopt(curl_handle_, CURLOPT_LOW_SPEED_LIMIT, 10),
>            CURLE_OK);
> -  CHECK_EQ(curl_easy_setopt(curl_handle_, CURLOPT_LOW_SPEED_TIME, 90),
> +  CHECK_EQ(curl_easy_setopt(curl_handle_, CURLOPT_LOW_SPEED_TIME, 3 * 60),
>            CURLE_OK);
>
>   CHECK_EQ(curl_multi_add_handle(curl_multi_handle_, curl_handle_),
> CURLM_OK);
> @@ -98,7 +98,7 @@ void LibcurlHttpFetcher::CurlPerformOnce() {
>     } else {
>       LOG(ERROR) << "Unable to get http response code.";
>     }
> -
> +
>     // we're done!
>     CleanUp();
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698