Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 3035020: Add "kern_guid=%U" to the secure boot kernel command-line template. (Closed)

Created:
10 years, 5 months ago by Bill Richardson
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git//crosutils.git
Visibility:
Public.

Description

Add "kern_guid=%U" to the secure boot kernel command-line template. With the newest Chrome OS BIOS and bootstub, this will be expanded to the booted kernel partition's UniqueGuid, so that the kernel device can be determined with certainty, since the BIOS and kernel may enumerate drives differently. You can identify the booted kernel partition at runtime with something like this: sudo cgpt find -1 -u \ $(cat /proc/cmdline | sed 's/.*kern_guid=\([0-9a-f-]\+\).*/\1/')

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build_kernel_image.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Richardson
10 years, 5 months ago (2010-07-23 01:31:24 UTC) #1
gauravsh
lgtm
10 years, 5 months ago (2010-07-23 01:46:29 UTC) #2
Bill Richardson
10 years, 5 months ago (2010-07-23 01:47:43 UTC) #3
Testing:

This is a multiple-repository change set. All three of these
changes must have landed before any changes will be visible:

  http://codereview.chromium.org/3056014/show
  http://codereview.chromium.org/2832078/show
  http://codereview.chromium.org/3035020/show

AND a Chrome OS BIOS that incorporates CL 3056014 must also
be used.

If all that has happened, boot the device, log in, switch to
a console, and run

  cat /proc/cmdline

You should see a term something like this (the actual
numbers will be different):

  kern_guid=af208ed8-788f-6841-b250-8654755089a3


That GUID should correspond to the kernel partition, which
you can display using the cgpt tool. For example,

  sudo cgpt show /dev/sda

Of course, you'll want to replace /dev/sda with the actual
root device (which you can find by running "rootdev").


If the kern_guid numbers are all zeros or a simple '%U' or
is not present at all, not all changes have landed (or
something is broken).

Powered by Google App Engine
This is Rietveld 408576698