Issue 3035017: Properly propagate failures from helper methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3035017: Properly propagate failures from helper methods. (Closed)

Created:
10 years, 5 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Properly propagate failures from helper methods. Otherwise failures are not reported and callback may fail to setup. Committed: http://code.google.com/p/v8/source/detail?r=5120

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/objects.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

antonm

Mads, may you have a look? If LGTMed, I'll bring this fix to previous branches ...

10 years, 5 months ago (2010-07-21 17:41:16 UTC) #1

Mads Ager (chromium)

10 years, 5 months ago (2010-07-22 06:11:12 UTC) #2

LGTM

I should have caught that in the review. Please do apply this to all the
branches that has this code.