Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 3035006: Reorder SharedFunctionInfo setup in lazy compile, quick fix for crbug.com/490... (Closed)

Created:
10 years, 5 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reorder SharedFunctionInfo setup in lazy compile, quick fix for crbug.com/49099 This fixes issue 49099 (http://crbug.com/49099) that makes chromium crash if a gc is triggered by setting the scopeinfo in CompileLazy. If this gc triggers code flushing the compiled function could be flushed, causing the ASSERT(shared->is_compiled()) to fail. By reordering the two methods we make sure that no allocation happens before the end of the method. Committed: http://code.google.com/p/v8/source/detail?r=5089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/compiler.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
I will investigate further the test crashes that I found by manually introducing a GC ...
10 years, 5 months ago (2010-07-19 06:24:56 UTC) #1
Mads Ager (chromium)
10 years, 5 months ago (2010-07-19 06:28:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698