src/x64/macro-assembler-x64.h - Issue 3034060: Create a new RegExp object for every evaluation of a RegExp literal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.h

Issue 3034060: Create a new RegExp object for every evaluation of a RegExp literal. (Closed)

Patch Set: Addressed review comments. Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/macro-assembler-x64.h

diff --git a/src/x64/macro-assembler-x64.h b/src/x64/macro-assembler-x64.h

index 7a90dd0175e5285669c086fba76ad450d568106b..a294ad678360e9ea2a7b95bbc7f15bfbce1b02f1 100644

--- a/src/x64/macro-assembler-x64.h

+++ b/src/x64/macro-assembler-x64.h

@@ -284,7 +284,9 @@ class MacroAssembler: public Assembler {

Condition CheckBothPositiveSmi(Register first, Register second);

// Are either value a tagged smi.

- Condition CheckEitherSmi(Register first, Register second);

+ Condition CheckEitherSmi(Register first,

+ Register second,

+ Register scratch = kScratchRegister);

// Is the value the minimum smi value (since we are using

// two's complement numbers, negating the value is known to yield

« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »