Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 3034051: Update parallel_emerge to use no-env-update feature which skips env_update. (Closed)

Created:
10 years, 4 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

Update parallel_emerge to use no-env-update feature which skips env_update. Currently, our build occasionally fails with errors about about symlinks already existing. This usually only slows down the build, because we have retries, but it would be good to fix the problem. This patch updates parallel_emerge to use the no-env-update feature for cross- compiles. This feature skips the env_update step, which isn't thread-safe, and isn't necessary for when we're cross-compiling and don't actually need to run the binaries. Instead we run the env_update at the end, avoiding a thread-safety issue. TEST=Ran full build --nousepkg with env_update occuring at end. BUG=chromium-os:5382

Patch Set 1 #

Patch Set 2 : Add period. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M parallel_emerge View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidjames
10 years, 4 months ago (2010-08-04 19:39:49 UTC) #1
Nick Sanders
10 years, 4 months ago (2010-08-04 19:58:03 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698