Issue 3034050: Add Java plugin group on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3034050: Add Java plugin group on Mac. (Closed)

Created:
10 years, 4 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, jam, darin-cc_chromium.org, mavrommatis

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Add Java plugin group on Mac. The plugin group only defines a more user-friendly name than "Java Plug-In 2 for NPAPI Browsers", no Java versions. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55040

Patch Set 1 #

Total comments: 1

Patch Set 2 : change update link #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/common/plugin_group.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

10 years, 4 months ago (2010-08-04 14:49:18 UTC) #2

LGTM.

http://codereview.chromium.org/3034050/diff/1/2
File chrome/common/plugin_group.cc (right):

http://codereview.chromium.org/3034050/diff/1/2#newcode22
chrome/common/plugin_group.cc:22:
"http://support.apple.com/kb/HT1338?viewlocale=en_US" },
You can probably skip the "?viewlocale=en_US" part of the URL. Then it might
even be smart enough to pick up the user's preferred locale sometimes....

Expand Messages | Collapse Messages