GTTF: Move more test server code from net/url_request/url_request_unittest.h

GTTF: Move more test server code from net/url_request/url_request_unittest.h
to net/test/test_server.h

No code changes, just a move.

TEST=none
BUG=49680
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54201

[eroman, 2010-07-28 21:08:47]

LGTM

http://codereview.chromium.org/3034038/diff/1/36
File net/test/test_server.h (right):

http://codereview.chromium.org/3034038/diff/1/36#newcode32
net/test/test_server.h:32: const std::string kDefaultHostName("localhost");
Can you convert this to a char[] instead (to avoid static initializer).

http://codereview.chromium.org/3034038/diff/1/36#newcode214
net/test/test_server.h:214: // Creates and returns a new HTTPTestServer. If
|loop| is non-null, requests
Please remove the comment about |loop|

http://codereview.chromium.org/3034038/diff/1/36#newcode241
net/test/test_server.h:241: virtual std::string scheme() { return "http"; }
I think we should use CapitalCasedFunctionName() for virtual methods. (Since
this is a move can probably leave it as is, but I suggest adding a TODO).

http://codereview.chromium.org/3034038/diff/1/36#newcode246
net/test/test_server.h:246: explicit HTTPSTestServer() {
No need for "explicit"

[huanr, 2010-07-29 15:00:04]

LGTM
On 2010/07/28 21:08:47, eroman wrote:
> LGTM
> 
> http://codereview.chromium.org/3034038/diff/1/36
> File net/test/test_server.h (right):
> 
> http://codereview.chromium.org/3034038/diff/1/36#newcode32
> net/test/test_server.h:32: const std::string kDefaultHostName("localhost");
> Can you convert this to a char[] instead (to avoid static initializer).
> 
> http://codereview.chromium.org/3034038/diff/1/36#newcode214
> net/test/test_server.h:214: // Creates and returns a new HTTPTestServer. If
> |loop| is non-null, requests
> Please remove the comment about |loop|
> 
> http://codereview.chromium.org/3034038/diff/1/36#newcode241
> net/test/test_server.h:241: virtual std::string scheme() { return "http"; }
> I think we should use CapitalCasedFunctionName() for virtual methods. (Since
> this is a move can probably leave it as is, but I suggest adding a TODO).
> 
> http://codereview.chromium.org/3034038/diff/1/36#newcode246
> net/test/test_server.h:246: explicit HTTPSTestServer() {
> No need for "explicit"