Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4705)

Unified Diff: chrome_frame/ole_document_impl.h

Issue 3034033: Our InPlaceMenu implementation is only partially being used.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/ole_document_impl.h
===================================================================
--- chrome_frame/ole_document_impl.h (revision 53623)
+++ chrome_frame/ole_document_impl.h (working copy)
@@ -209,7 +209,11 @@
hr = t->ActiveXDocActivate(OLEIVERB_UIACTIVATE);
}
} else {
- t->InPlaceMenuDestroy();
+ // Menu integration is still not complete, so do not destroy
+ // IE's menus. If we call InPlaceMenuDestroy here, menu items such
+ // as Print etc will be disabled and we will not get calls to QueryStatus
+ // for those commands.
+ // t->InPlaceMenuDestroy();
// t->DestroyToolbar();
hr = t->UIDeactivate();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698