Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 3034030: image_to_vm: convert to calling setimage directly (Closed)

Created:
10 years, 5 months ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
rkc, zel
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
http://src.chromium.org/git/crosutils.git
Visibility:
Public.

Description

image_to_vm: convert to calling setimage directly The last changes to the installer broke image_to_vm. Since image_to_vm doesn't need to run postinst, but just change the active image, it now just calls chromeos-setimage and passes in its needed flags (already supported by the last installer change). It will also detect whether the image was built with verification of the rootfs enabled or not by looking at the default.cfg file. Also updates the location of where you should run the command in build_image. TEST=built a new image with --enable_rootfs_verification and started with qemu -curses -hda [output]; did the same without verification BUG=chromium-os:2963

Patch Set 1 #

Total comments: 2

Patch Set 2 : tabs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M build_image View 1 chunk +1 line, -1 line 0 comments Download
M image_to_vm.sh View 1 3 chunks +36 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Will Drewry
10 years, 5 months ago (2010-07-23 20:15:24 UTC) #1
zel
LGTM + a minor issue, rkc should be the ultimate reviewer of this change http://codereview.chromium.org/3034030/diff/1/3 ...
10 years, 5 months ago (2010-07-23 20:44:54 UTC) #2
Will Drewry
Nice catch - thanks! I should learn not to edit files under the chroot :) ...
10 years, 5 months ago (2010-07-23 21:43:15 UTC) #3
Will Drewry
10 years, 5 months ago (2010-07-24 12:41:12 UTC) #4
Imma moron.  I pushed this after the style fixes without thinking.
Sorry!  @rkc@ let me know what you'd like fixed up.

cheers! will

On Fri, Jul 23, 2010 at 4:43 PM,  <wad@chromium.org> wrote:
> Nice catch - thanks!  I should learn not to edit files under the chroot :)
>
>
> http://codereview.chromium.org/3034030/diff/1/3
> File image_to_vm.sh (right):
>
> http://codereview.chromium.org/3034030/diff/1/3#newcode217
> image_to_vm.sh:217: --rootfs_image="${TEMP_ROOTFS}" \
> On 2010/07/23 20:44:55, zel wrote:
>>
>> tabs?
>
> Done.
>
> http://codereview.chromium.org/3034030/show
>

Powered by Google App Engine
This is Rietveld 408576698