Use check item for side tab menu.

Use check item for side tab menu.

BUG=chromium-os:4948
TEST=manual: toggle side tab from wrench menu and side tab menu will be checked.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53235

[sky, 2010-07-21 17:18:18]

LGTM with the following change.

http://codereview.chromium.org/3034021/diff/4001/5001
File chrome/browser/views/toolbar_view.cc (right):

http://codereview.chromium.org/3034021/diff/4001/5001#newcode369
chrome/browser/views/toolbar_view.cc:369: return
static_cast<BrowserView*>(browser_->window())
return browser_->UseVerticalTabs();

[oshima, 2010-07-21 17:25:33]

On 2010/07/21 17:18:18, sky wrote:
> LGTM with the following change.
> 
> http://codereview.chromium.org/3034021/diff/4001/5001
> File chrome/browser/views/toolbar_view.cc (right):
> 
> http://codereview.chromium.org/3034021/diff/4001/5001#newcode369
> chrome/browser/views/toolbar_view.cc:369: return
> static_cast<BrowserView*>(browser_->window())
> return browser_->UseVerticalTabs();
This method is private now. Is it okay to move to public?

[sky, 2010-07-21 17:36:47]

Yes, make it public.

  -Scott

On Wed, Jul 21, 2010 at 10:25 AM,  <oshima@chromium.org> wrote:
> On 2010/07/21 17:18:18, sky wrote:
>>
>> LGTM with the following change.
>
>> http://codereview.chromium.org/3034021/diff/4001/5001
>> File chrome/browser/views/toolbar_view.cc (right):
>
>> http://codereview.chromium.org/3034021/diff/4001/5001#newcode369
>> chrome/browser/views/toolbar_view.cc:369: return
>> static_cast<BrowserView*>(browser_->window())
>> return browser_->UseVerticalTabs();
>
> This method is private now. Is it okay to move to public?
>
>
> http://codereview.chromium.org/3034021/show
>

[oshima, 2010-07-21 19:27:51]

On 2010/07/21 17:36:47, sky wrote:
> Yes, make it public.
> 

done. can you take another look?

- oshima
>   -Scott
> 
> On Wed, Jul 21, 2010 at 10:25 AM,  <mailto:oshima@chromium.org> wrote:
> > On 2010/07/21 17:18:18, sky wrote:
> >>
> >> LGTM with the following change.
> >
> >> http://codereview.chromium.org/3034021/diff/4001/5001
> >> File chrome/browser/views/toolbar_view.cc (right):
> >
> >> http://codereview.chromium.org/3034021/diff/4001/5001#newcode369
> >> chrome/browser/views/toolbar_view.cc:369: return
> >> static_cast<BrowserView*>(browser_->window())
> >> return browser_->UseVerticalTabs();
> >
> > This method is private now. Is it okay to move to public?
> >
> >
> > http://codereview.chromium.org/3034021/show
> >
>

[sky, 2010-07-21 19:39:31]

LGTM