Issue 3034013: Fetch the translate script regularly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3034013: Fetch the translate script regularly (Closed)

Created:
10 years, 5 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, John Grabowski, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Makes the browser fetch the translate script regularly. New versions of that script may get pushed from time to time. Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions. Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide). BUG=None TEST=Run the unit-tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53220

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -76 lines)			Patch
M	chrome/browser/cocoa/translate/translate_infobar_base.mm	View	3	4 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/cocoa/translate/translate_infobar_unittest.mm	View		6 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/cocoa/translate/translate_message_infobar_controller.mm	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/translate/translate_infobar_base_gtk.cc	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/translate/translate_infobar_delegate.h	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/translate/translate_infobar_delegate.cc	View		11 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/translate/translate_manager.h	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/translate/translate_manager.cc	View	1 2	6 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/translate/translate_manager_unittest.cc	View	1	15 chunks	+60 lines, -13 lines	0 comments	Download
M	chrome/browser/views/infobars/translate_infobar_base.cc	View		2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 3034013: Fetch the translate script regularly (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixing unit-tests build #

Patch Set 3 : Fixed Mac and Linux build #

Patch Set 4 : Synced #

Messages