Issue 3034004: Adding gpu_info to the breakpad info collection before sending off a crash....

Issue 3034004: Adding gpu_info to the breakpad info collection before sending off a crash.... (Closed)

Created:
10 years, 5 months ago by rpetterson

Modified:
9 years, 7 months ago

Reviewers:
huanr, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adding gpu_info to the breakpad info collection before sending off a crash. BUG=38737 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52884

Patch Set 6 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -1 line)			Patch
M	chrome/app/breakpad_win.cc	View	1 2 3 4 5	4 chunks	+35 lines, -1 line	0 comments	Download
M	chrome/browser/gpu_process_host.cc	View	1 2 3 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/child_process_logging.h	View	1 2 3 4 5	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/child_process_logging_linux.cc	View	1 2 3 4 5	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/common/child_process_logging_mac.mm	View	1 2 3 4 5	3 chunks	+37 lines, -0 lines	0 comments	Download
M	chrome/common/child_process_logging_win.cc	View	1 2 3 4 5	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rpetterson

Linux isn't in here yet as I'll need some advice for integrating there, but mac ...

10 years, 5 months ago (2010-07-16 01:33:18 UTC) #1

cpu_(ooo_6.6-7.5)

lgtm with the nits below http://codereview.chromium.org/3034004/diff/2003/10004 File chrome/common/child_process_logging.h (right): http://codereview.chromium.org/3034004/diff/2003/10004#newcode13 chrome/common/child_process_logging.h:13: #include "chrome/common/gpu_info.h" fix sort ...

10 years, 5 months ago (2010-07-16 17:34:13 UTC) #2

rpetterson

10 years, 5 months ago (2010-07-16 18:08:26 UTC) #3

Will check in once everything's green.

http://codereview.chromium.org/3034004/diff/2003/10004
File chrome/common/child_process_logging.h (right):

http://codereview.chromium.org/3034004/diff/2003/10004#newcode13
chrome/common/child_process_logging.h:13: #include "chrome/common/gpu_info.h"
On 2010/07/16 17:34:13, cpu wrote:
> fix sort

Done.

http://codereview.chromium.org/3034004/diff/2003/10004#newcode39
chrome/common/child_process_logging.h:39: // Sets the data on the gpu to send
along with crash reports
On 2010/07/16 17:34:13, cpu wrote:
> period at the end of comments.

Done.

http://codereview.chromium.org/3034004/diff/2003/10005
File chrome/common/child_process_logging_linux.cc (right):

http://codereview.chromium.org/3034004/diff/2003/10005#newcode39
chrome/common/child_process_logging_linux.cc:39: // TODO(rlp)
On 2010/07/16 17:34:13, cpu wrote:
> period. Ideally this has a bug number associated with it.

Done.

Expand Messages | Collapse Messages