Issue 3034003: Land new resource for content-setting images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3034003: Land new resource for content-setting images. (Closed)

Created:
10 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Land new resource for content-setting images. Additionally, note in the Mac code that the icon padding is the same as for views. Because that's what the bug was originally about. BUG=42485 TEST=content settings still look right. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52610

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -2 lines)			Patch
M	chrome/app/theme/blocked_cookies.png	View	Binary file		0 comments	Download
M	chrome/app/theme/blocked_images.png	View	Binary file		0 comments	Download
M	chrome/app/theme/blocked_javascript.png	View	Binary file		0 comments	Download
M	chrome/app/theme/blocked_plugins.png	View	Binary file		0 comments	Download
M	chrome/app/theme/blocked_popups.png	View	Binary file		0 comments	Download
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

On the bug, you mention potentially needing to re-align the Windows code. I can't see ...

10 years, 5 months ago (2010-07-15 23:51:43 UTC) #1

Scott Hess - ex-Googler

On 2010/07/15 23:52:57, Peter Kasting wrote: > LGTM if you test-ran it and it looked ...

10 years, 5 months ago (2010-07-16 00:10:59 UTC) #3

Peter Kasting

10 years, 5 months ago (2010-07-16 00:17:19 UTC) #4

Just go ahead and land, I'll pay attention to this stuff as I rework the theme
images.

Expand Messages | Collapse Messages