Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 3033044: Remove valgrind suppressions from bugs 50728 and 50766 (Closed)

Created:
10 years, 4 months ago by Brian Ryner
Modified:
9 years, 7 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Remove valgrind suppressions from bugs 50728 and 50766 The underlying cause of these errors was fixed in http://codereview.chromium.org/2873081/show . BUG=none TEST=valgrind tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54997

Patch Set 1 #

Patch Set 2 : remove additional suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -72 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 2 chunks +0 lines, -72 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Brian Ryner
10 years, 4 months ago (2010-07-31 01:13:05 UTC) #1
cbentzel
10 years, 4 months ago (2010-07-31 09:54:25 UTC) #2
LGTM

On Fri, Jul 30, 2010 at 9:13 PM, <bryner@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Description:
> The underlying cause of these errors was fixed in
> http://codereview.chromium.org/2873081/show .
>
>
> Please review this at http://codereview.chromium.org/3033044/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
26ec254b7f50b88818d17e3db1d59e2d09491d4e..c202c41bf73b731ae1ff8687c0b7adf4df193d0a
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -3615,52 +3615,6 @@
>    fun:_ZN9OptionsUIC1EP11TabContents
>  }
>  {
> -   bug_50728_a
> -   Memcheck:Cond
> -   ...
> -
>
fun:_ZNK7WebCore16CSSStyleSelector15SelectorChecker26determineLinkStateSlowCaseEPNS_7ElementE
> -
>
fun:_ZNK7WebCore16CSSStyleSelector15SelectorChecker18determineLinkStateEPNS_7ElementE
> -   fun:_ZN7WebCore16CSSStyleSelector11initElementEPNS_7ElementE
> -
>
fun:_ZN7WebCore16CSSStyleSelector15styleForElementEPNS_7ElementEPNS_11RenderStyleEbbb
> -   fun:_ZN7WebCore4Node16styleForRendererEv
> -   fun:_ZN7WebCore4Node22createRendererIfNeededEv
> -   fun:_ZN7WebCore7Element6attachEv
> -   fun:_ZN7WebCore21LegacyHTMLTreeBuilder10insertNodeEPNS_4NodeEb
> -
> fun:_ZN7WebCore21LegacyHTMLTreeBuilder25insertNodeAfterLimitDepthEPNS_4NodeEb
> -   fun:_ZN7WebCore21LegacyHTMLTreeBuilder10parseTokenEPNS_5TokenE
> -
> fun:_ZN7WebCore15HTMLTreeBuilder23passTokenToLegacyParserERNS_9HTMLTokenE
> -
> fun:_ZN7WebCore15HTMLTreeBuilder22constructTreeFromTokenERNS_9HTMLTokenE
> -
> fun:_ZN7WebCore18HTMLDocumentParser13pumpTokenizerENS0_15SynchronousModeE
> -
>
fun:_ZN7WebCore18HTMLDocumentParser23pumpTokenizerIfPossibleENS0_15SynchronousModeE
> -   fun:_ZN7WebCore18HTMLDocumentParser6appendERKNS_15SegmentedStringE
> -
>
fun:_ZN7WebCore25DecodedDataDocumentParser11appendBytesEPNS_14DocumentWriterEPKcib
> -   fun:_ZN7WebCore14DocumentWriter7addDataEPKcib
> -   fun:_ZN7WebCore14DocumentWriter27endIfNotLoadingMainResourceEv
> -}
> -{
> -   bug_50728_b
> -   Memcheck:Value4
> -   ...
> -
>
fun:_ZNK7WebCore16CSSStyleSelector15SelectorChecker26determineLinkStateSlowCaseEPNS_7ElementE
> -
>
fun:_ZNK7WebCore16CSSStyleSelector15SelectorChecker18determineLinkStateEPNS_7ElementE
> -   fun:_ZN7WebCore16CSSStyleSelector11initElementEPNS_7ElementE
> -
>
fun:_ZN7WebCore16CSSStyleSelector15styleForElementEPNS_7ElementEPNS_11RenderStyleEbbb
> -   fun:_ZN7WebCore4Node16styleForRendererEv
> -   fun:_ZN7WebCore4Node22createRendererIfNeededEv
> -   fun:_ZN7WebCore7Element6attachEv
> -   fun:_ZN7WebCore21LegacyHTMLTreeBuilder10insertNodeEPNS_4NodeEb
> -
> fun:_ZN7WebCore21LegacyHTMLTreeBuilder25insertNodeAfterLimitDepthEPNS_4NodeEb
> -   fun:_ZN7WebCore21LegacyHTMLTreeBuilder10parseTokenEPNS_5TokenE
> -
> fun:_ZN7WebCore15HTMLTreeBuilder23passTokenToLegacyParserERNS_9HTMLTokenE
> -
> fun:_ZN7WebCore15HTMLTreeBuilder22constructTreeFromTokenERNS_9HTMLTokenE
> -
> fun:_ZN7WebCore18HTMLDocumentParser13pumpTokenizerENS0_15SynchronousModeE
> -
>
fun:_ZN7WebCore18HTMLDocumentParser23pumpTokenizerIfPossibleENS0_15SynchronousModeE
> -   fun:_ZN7WebCore18HTMLDocumentParser6appendERKNS_15SegmentedStringE
> -
>
fun:_ZN7WebCore25DecodedDataDocumentParser11appendBytesEPNS_14DocumentWriterEPKcib
> -   fun:_ZN7WebCore14DocumentWriter7addDataEPKcib
> -   fun:_ZN7WebCore14DocumentWriter27endIfNotLoadingMainResourceEv
> -}
> -{
>    bug_50729
>    Memcheck:Leak
>    fun:_Znw*
> @@ -3692,29 +3646,3 @@
>    ...
>    fun:_ZN19DownloadsDOMHandler12ModelChangedEv
>  }
> -{
> -   bug_50766
> -   Memcheck:Cond
> -
>
fun:_ZN3WTF9HashTableIyyNS_17IdentityExtractorIyEEN7WebCore12LinkHashHashENS_10HashTraitsIyEES6_E3addIyyNS_22IdentityHashTranslatorIyyS4_EEEESt4pairINS_17HashTableIteratorIyyS2_S4_S6_S6_EEbERKT_RKT0_
> -
> fun:_ZN3WTF7HashSetIyN7WebCore12LinkHashHashENS_10HashTraitsIyEEE3addERKy
> -
>
fun:_ZNK7WebCore16CSSStyleSelector15SelectorChecker26determineLinkStateSlowCaseEPNS_7ElementE
> -   fun:_ZN7WebCore16CSSStyleSelector11initElementEPNS_7ElementE
> -
>
fun:_ZN7WebCore16CSSStyleSelector15styleForElementEPNS_7ElementEPNS_11RenderStyleEbbb
> -   fun:_ZN7WebCore4Node16styleForRendererEv
> -   fun:_ZN7WebCore4Node22createRendererIfNeededEv
> -   fun:_ZN7WebCore7Element6attachEv
> -   fun:_ZN7WebCore21LegacyHTMLTreeBuilder10insertNodeEPNS_4NodeEb
> -
> fun:_ZN7WebCore21LegacyHTMLTreeBuilder25insertNodeAfterLimitDepthEPNS_4NodeEb
> -   fun:_ZN7WebCore21LegacyHTMLTreeBuilder10parseTokenEPNS_5TokenE
> -
> fun:_ZN7WebCore15HTMLTreeBuilder23passTokenToLegacyParserERNS_9HTMLTokenE
> -
> fun:_ZN7WebCore15HTMLTreeBuilder22constructTreeFromTokenERNS_9HTMLTokenE
> -
> fun:_ZN7WebCore18HTMLDocumentParser13pumpTokenizerENS0_15SynchronousModeE
> -   fun:_ZN7WebCore18HTMLDocumentParser6appendERKNS_15SegmentedStringE
> -
>
fun:_ZN7WebCore25DecodedDataDocumentParser11appendBytesEPNS_14DocumentWriterEPKcib
> -   fun:_ZN7WebCore14DocumentWriter7addDataEPKcib
> -   fun:_ZN7WebCore14DocumentWriter27endIfNotLoadingMainResourceEv
> -   fun:_ZN7WebCore11FrameLoader15finishedLoadingEv
> -   fun:_ZN7WebCore18MainResourceLoader16didFinishLoadingEv
> -
>
fun:_ZN11webkit_glue16WebURLLoaderImpl7Context18OnCompletedRequestERK16URLRequestStatusRKSs
> -
> fun:_ZN18ResourceDispatcher17OnRequestCompleteEiRK16URLRequestStatusRKSs
> -}
>
>
>

Powered by Google App Engine
This is Rietveld 408576698