Remove tips from NTP.

Remove tips from NTP.

BUG=50072
TEST= no tips on NTP.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54045

[Miranda Callahan, 2010-07-28 00:01:42]

Hi, Erik -- this is the first part of removing tips from the NTP.  I have a
question about the CSS properties for the option button, which now needs to sit
at the far right of the page -- I've set the button's margin-left property for
wide and narrow pages, but this property is not loading correctly for the wide
setting (margin-left: 900px), and I'm not sure why (it loads correctly for the
narrower setting).

Here's the rub: margin-left shows up as 900px (correct) in the element inspector
for the #option-button on the NTP, even though the computed property is 10px
(incorrect).  BUT when I simply check and uncheck the margin-left: 900px
property in the inspector for #option-button, it now works correctly.  ??

[arv (Not doing code reviews), 2010-07-28 01:49:26]

I'll be in all day meetings tomorrow and Thursday so I doubt I'll be able to
look at this until Friday.

Can you use absolute position and right 0?

On Jul 27, 2010 5:01 PM, <mirandac@chromium.org> wrote:
> Reviewers: arv,
>
> Message:
> Hi, Erik -- this is the first part of removing tips from the NTP. I have a
> question about the CSS properties for the option button, which now needs
to
> sit
> at the far right of the page -- I've set the button's margin-left property

> for
> wide and narrow pages, but this property is not loading correctly for the
> wide
> setting (margin-left: 900px), and I'm not sure why (it loads correctly for

> the
> narrower setting).
>
> Here's the rub: margin-left shows up as 900px (correct) in the element
> inspector
> for the #option-button on the NTP, even though the computed property is
10px
> (incorrect). BUT when I simply check and uncheck the margin-left: 900px
> property in the inspector for #option-button, it now works correctly. ??
>
>
>
> Description:
> Remove tips from NTP.
>
> BUG= 50072
> TEST= no tips on NTP.
>
> Please review this at http://codereview.chromium.org/3033032/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> M chrome/browser/dom_ui/new_tab_ui.cc
> M chrome/browser/profile.h
> M chrome/browser/profile.cc
> M chrome/browser/profile_manager.cc
> M chrome/browser/resources/new_new_tab.css
> M chrome/browser/resources/new_new_tab.html
> M chrome/browser/resources/new_new_tab.js
>
>

[Miranda Callahan, 2010-07-28 02:51:33]

On 2010/07/28 01:49:26, arv wrote:
> I'll be in all day meetings tomorrow and Thursday so I doubt I'll be able to
> look at this until Friday.
> 
> Can you use absolute position and right 0?

Yes, perfect, works like a charm!  Will find someone else to review then --
thanks!

[feldstein, 2010-07-28 06:21:51]

LGTM.

[arv (Not doing code reviews), 2010-07-28 06:27:29]

LGTM

Did you verify that the notification still work OK?

[Miranda Callahan, 2010-07-28 21:41:06]

On 2010/07/28 06:27:29, arv wrote:
> LGTM
> 
> Did you verify that the notification still work OK?

Yes, I verified on the opening "this will show most visited" notification, and
on the "Thumbnail removed. Undo" notifications.  Also, I made one small change
-- added

top: 20px;

to the css file for the option-button, because it was sitting at the top of the
box, instead of in the middle.  Thanks for the quick response -- if one of you
could just verify that this change is ok, I'll commit.

[feldstein, 2010-07-28 21:42:24]

Still lgtm.