Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: chrome/browser/configuration_policy_provider_win_unittest.cc

Issue 3033030: [win] Don't initialize the crash reporter on windows if disabled by configuration management. (Closed) Base URL: ssh://mnissler@kea.muc/usr/local/google/home/mnissler/chrome/src/
Patch Set: Allow policy to force-enable metrics reporting. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/configuration_policy_provider_win_unittest.cc
diff --git a/chrome/browser/configuration_policy_provider_win_unittest.cc b/chrome/browser/configuration_policy_provider_win_unittest.cc
index 6197780e8f7bd830f18fc5fb3a35c123708fe174..4d39ff62ae74afe913435553e434598cb5bf0478 100644
--- a/chrome/browser/configuration_policy_provider_win_unittest.cc
+++ b/chrome/browser/configuration_policy_provider_win_unittest.cc
@@ -14,6 +14,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/configuration_policy_provider_win.h"
#include "chrome/browser/mock_configuration_policy_store.h"
+#include "chrome/common/policy_constants.h"
#include "chrome/common/pref_names.h"
namespace {
@@ -64,9 +65,7 @@ std::wstring NameForPolicy(ConfigurationPolicyStore::PolicyType policy) {
void TestConfigurationPolicyProviderWin::SetHomepageRegistryValue(
HKEY hive,
const wchar_t* value) {
- RegKey key(hive,
- ConfigurationPolicyProviderWin::kPolicyRegistrySubKey,
- KEY_ALL_ACCESS);
+ RegKey key(hive, policy::kRegistrySubKey, KEY_ALL_ACCESS);
EXPECT_TRUE(key.WriteValue(
NameForPolicy(ConfigurationPolicyStore::kPolicyHomePage).c_str(),
value));
@@ -74,9 +73,7 @@ void TestConfigurationPolicyProviderWin::SetHomepageRegistryValue(
void TestConfigurationPolicyProviderWin::SetHomepageRegistryValueWrongType(
HKEY hive) {
- RegKey key(hive,
- ConfigurationPolicyProviderWin::kPolicyRegistrySubKey,
- KEY_ALL_ACCESS);
+ RegKey key(hive, policy::kRegistrySubKey, KEY_ALL_ACCESS);
EXPECT_TRUE(key.WriteValue(
NameForPolicy(ConfigurationPolicyStore::kPolicyHomePage).c_str(),
5));
@@ -86,8 +83,7 @@ void TestConfigurationPolicyProviderWin::SetBooleanPolicy(
ConfigurationPolicyStore::PolicyType type,
HKEY hive,
bool value) {
- RegKey key(hive, ConfigurationPolicyProviderWin::kPolicyRegistrySubKey,
- KEY_ALL_ACCESS);
+ RegKey key(hive, policy::kRegistrySubKey, KEY_ALL_ACCESS);
EXPECT_TRUE(key.WriteValue(NameForPolicy(type).c_str(), value));
}
@@ -312,4 +308,3 @@ TEST_F(ConfigurationPolicyProviderWinTest,
TestPolicyPasswordManagerEnabled) {
TestBooleanPolicy(ConfigurationPolicyStore::kPolicyPasswordManagerEnabled);
}
-

Powered by Google App Engine
This is Rietveld 408576698