Issue 3033003: Make conditional requests when updating the appcache....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3033003: Make conditional requests when updating the appcache.... (Closed)

Created:
10 years, 5 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, michaeln, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make conditional requests when updating the appcache. TEST=altered existing tests to also cover this case BUG=49548 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53230

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -86 lines)			Patch
M	webkit/appcache/appcache_update_job.h	View	1 2 3 4	6 chunks	+18 lines, -7 lines	0 comments	Download
M	webkit/appcache/appcache_update_job.cc	View	1 2 3 4	21 chunks	+97 lines, -76 lines	1 comment	Download
M	webkit/appcache/appcache_update_job_unittest.cc	View		13 chunks	+55 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

10 years, 5 months ago (2010-07-20 19:17:18 UTC) #2

LGTM

http://codereview.chromium.org/3033003/diff/16001/17001
File webkit/appcache/appcache_update_job.cc (right):

http://codereview.chromium.org/3033003/diff/16001/17001#newcode629
webkit/appcache/appcache_update_job.cc:629: // Copy the response from the newest
complete cache.
maybe change from the newest complete cache -> from the existing entry
(same at line 644)

Expand Messages | Collapse Messages