Issue 3032064: Changed layout of object literal parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3032064: Changed layout of object literal parser. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Changed layout of object literal parser.

Patch Set 2 : Addressed review comment. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -41 lines)			Patch
	M	src/parser.cc	View	1	5 chunks	+52 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/3032064/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/3032064/diff/1/2#newcode3678 src/parser.cc:3678: // Expectation is guaranteed to fail. I know ...

10 years, 4 months ago (2010-08-09 08:45:50 UTC) #2

Lasse Reichstein

10 years, 4 months ago (2010-08-09 08:55:56 UTC) #3

http://codereview.chromium.org/3032064/diff/1/2
File src/parser.cc (right):

http://codereview.chromium.org/3032064/diff/1/2#newcode3678
src/parser.cc:3678: // Expectation is guaranteed to fail.
I inlined the code of the Expect function and removed the check (i.e., just
inline the unexpected token error handling).

Expand Messages | Collapse Messages

Issue 3032064: Changed layout of object literal parser. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comment. #

Messages