Move creation of the PrefStores into the PrefValueStore, to reduce the knowle...

chrome/browser/pref_value_store_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/scoped_ptr.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/configuration_policy_pref_store.h"
+#include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/dummy_pref_store.h"
 #include "chrome/browser/pref_value_store.h"
+#include "chrome/test/testing_pref_service.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::_;
 using testing::Mock;
 
 // Names of the preferences used in this test program.
 namespace prefs {
   const wchar_t kCurrentThemeID[] = L"extensions.theme.id";
   const wchar_t kDeleteCache[] = L"browser.clear_data.cache";
@@ skipping 57 matching lines @@
     extension_pref_store_->set_prefs(extension_prefs_);
     command_line_pref_store_ = new DummyPrefStore();
     command_line_pref_store_->set_prefs(command_line_prefs_);
     user_pref_store_ = new DummyPrefStore();
     user_pref_store_->set_read_only(false);
     user_pref_store_->set_prefs(user_prefs_);
     recommended_pref_store_ = new DummyPrefStore();
     recommended_pref_store_->set_prefs(recommended_prefs_);
 
     // Create a new pref-value-store.
-    pref_value_store_ = new PrefValueStore(enforced_pref_store_,
-                                           extension_pref_store_,
-                                           command_line_pref_store_,
-                                           user_pref_store_,
-                                           recommended_pref_store_);
+    pref_value_store_ = new TestingPrefService::TestingPrefValueStore(
+        enforced_pref_store_,
+        extension_pref_store_,
+        command_line_pref_store_,
+        user_pref_store_,
+        recommended_pref_store_);
 
     ui_thread_.reset(new ChromeThread(ChromeThread::UI, &loop_));
     file_thread_.reset(new ChromeThread(ChromeThread::FILE, &loop_));
   }
 
   // Creates a new dictionary and stores some sample user preferences
   // in it.
   DictionaryValue* CreateUserPrefs() {
     DictionaryValue* user_prefs = new DictionaryValue();
     user_prefs->SetBoolean(prefs::kDeleteCache, user_pref::kDeleteCacheValue);
@@ skipping 66 matching lines @@
     sample_list->Set(3, Value::CreateIntegerValue(3));
     return sample_list;
   }
 
   virtual void TearDown() {
     loop_.RunAllPending();
   }
 
   MessageLoop loop_;
 
-  scoped_refptr<PrefValueStore> pref_value_store_;
+  scoped_refptr<TestingPrefService::TestingPrefValueStore> pref_value_store_;
 
   // |PrefStore|s are owned by the |PrefValueStore|.
   DummyPrefStore* enforced_pref_store_;
   DummyPrefStore* extension_pref_store_;
   DummyPrefStore* command_line_pref_store_;
   DummyPrefStore* recommended_pref_store_;
   DummyPrefStore* user_pref_store_;
 
   // A vector of the preferences paths in the managed and recommended
   // PrefStores that are set at the beginning of a test. Can be modified
@@ skipping 392 matching lines @@
   Mock::VerifyAndClearExpectations(&callback1);
   Mock::VerifyAndClearExpectations(&callback2);
   Mock::VerifyAndClearExpectations(&callback3);
 
   EXPECT_CALL(callback1, DoCallback(expected_differing_paths_)).Times(1);
   std::vector<std::string> no_differing_paths;
   EXPECT_CALL(callback2, DoCallback(no_differing_paths)).Times(1);
   EXPECT_CALL(callback3, DoCallback(no_differing_paths)).Times(1);
   loop_.RunAllPending();
 }