Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 3032057: Sort the language list by locale specific sorter. (Closed)

Created:
10 years, 4 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Sort the language list by locale specific sorter. TEST=manually BUG=chromium-os:4573 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55172

Patch Set 1 #

Patch Set 2 : fix comments #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M chrome/browser/chromeos/dom_ui/language_options_handler.cc View 1 2 2 chunks +37 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
10 years, 4 months ago (2010-08-05 10:10:23 UTC) #1
Yusuke Sato
http://codereview.chromium.org/3032057/diff/2001/3001 File chrome/browser/chromeos/dom_ui/language_options_handler.cc (right): http://codereview.chromium.org/3032057/diff/2001/3001#newcode8 chrome/browser/chromeos/dom_ui/language_options_handler.cc:8: #include <utility> - please include <string> just in case. ...
10 years, 4 months ago (2010-08-06 01:22:20 UTC) #2
satorux1
http://codereview.chromium.org/3032057/diff/2001/3001 File chrome/browser/chromeos/dom_ui/language_options_handler.cc (right): http://codereview.chromium.org/3032057/diff/2001/3001#newcode8 chrome/browser/chromeos/dom_ui/language_options_handler.cc:8: #include <utility> On 2010/08/06 01:22:20, Yusuke Sato wrote: > ...
10 years, 4 months ago (2010-08-06 01:24:19 UTC) #3
Yusuke Sato
10 years, 4 months ago (2010-08-06 01:27:18 UTC) #4
LGTM

On 2010/08/06 01:24:19, satorux1 wrote:
> http://codereview.chromium.org/3032057/diff/2001/3001
> File chrome/browser/chromeos/dom_ui/language_options_handler.cc (right):
> 
> http://codereview.chromium.org/3032057/diff/2001/3001#newcode8
> chrome/browser/chromeos/dom_ui/language_options_handler.cc:8: #include
<utility>
> On 2010/08/06 01:22:20, Yusuke Sato wrote:
> > - please include <string> just in case.
> > - one vertical space betweel line 8 and 9 please.
> > 
> 
> Done.
> 
> http://codereview.chromium.org/3032057/diff/2001/3001#newcode97
> chrome/browser/chromeos/dom_ui/language_options_handler.cc:97: // display
names
> usign ICU coomparator, but doing it is hard, thus we'll
> On 2010/08/06 01:22:20, Yusuke Sato wrote:
> > 2 typos: using comparator
> > 
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698