Issue 3032038: The button menu items on GTK menus honor the enabled state of the command....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3032038: The button menu items on GTK menus honor the enabled state of the command.... (Closed)

Created:
10 years, 4 months ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The button menu items on GTK menus honor the enabled state of the command. BUG=None TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54162

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -20 lines)			Patch
M	app/menus/button_menu_item_model.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	app/menus/button_menu_item_model.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/menu_gtk.cc	View	1 2	4 chunks	+20 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages