Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: chrome/browser/autofill/autofill_manager_unittest.cc

Issue 3032034: Disable AutoFillManagerTest tests in branded builds.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager_unittest.cc
===================================================================
--- chrome/browser/autofill/autofill_manager_unittest.cc (revision 54052)
+++ chrome/browser/autofill/autofill_manager_unittest.cc (working copy)
@@ -280,7 +280,15 @@
DISALLOW_COPY_AND_ASSIGN(AutoFillManagerTest);
};
-TEST_F(AutoFillManagerTest, GetProfileSuggestionsEmptyValue) {
+// TODO(georgey): All of these tests crash in official
+// builds. http://crbug.com/50537
+#if defined(GOOGLE_CHROME_BUILD)
+#define SKIP_BRANDED(test) DISABLED_##test
+#else
+#define SKIP_BRANDED(test) test
+#endif
+
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(GetProfileSuggestionsEmptyValue)) {
FormData form;
CreateTestFormData(&form);
@@ -318,7 +326,7 @@
EXPECT_EQ(ASCIIToUTF16("123 Apple St."), labels[1]);
}
-TEST_F(AutoFillManagerTest, GetProfileSuggestionsMatchCharacter) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(GetProfileSuggestionsMatchCharacter)) {
FormData form;
CreateTestFormData(&form);
@@ -352,7 +360,7 @@
EXPECT_EQ(ASCIIToUTF16("3734 Elvis Presley Blvd."), labels[0]);
}
-TEST_F(AutoFillManagerTest, GetCreditCardSuggestionsEmptyValue) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(GetCreditCardSuggestionsEmptyValue)) {
FormData form;
CreateTestFormDataBilling(&form);
@@ -396,7 +404,8 @@
EXPECT_EQ(ASCIIToUTF16("Empty; *8765"), labels[5]);
}
-TEST_F(AutoFillManagerTest, GetCreditCardSuggestionsMatchCharacter) {
+TEST_F(AutoFillManagerTest,
+ SKIP_BRANDED(GetCreditCardSuggestionsMatchCharacter)) {
FormData form;
CreateTestFormDataBilling(&form);
@@ -434,7 +443,7 @@
EXPECT_EQ(ASCIIToUTF16("Empty; *3456"), labels[2]);
}
-TEST_F(AutoFillManagerTest, GetCreditCardSuggestionsNonCCNumber) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(GetCreditCardSuggestionsNonCCNumber)) {
FormData form;
CreateTestFormDataBilling(&form);
@@ -478,7 +487,7 @@
EXPECT_EQ(ASCIIToUTF16("Empty; *8765"), labels[5]);
}
-TEST_F(AutoFillManagerTest, GetCreditCardSuggestionsSemicolon) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(GetCreditCardSuggestionsSemicolon)) {
// |profile| will be owned by the mock PersonalDataManager.
AutoFillProfile* profile = new AutoFillProfile;
autofill_unittest::SetProfileInfo(profile, "Home; 8765", "Joe", "", "Ely",
@@ -535,7 +544,7 @@
EXPECT_EQ(ASCIIToUTF16("Home; 8765; *8765"), labels[7]);
}
-TEST_F(AutoFillManagerTest, GetCreditCardSuggestionsNonHTTPS) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(GetCreditCardSuggestionsNonHTTPS)) {
FormData form;
CreateTestFormDataBilling(&form);
form.origin = GURL("http://myform.com/form.html");
@@ -556,7 +565,8 @@
autofill_manager_->GetAutoFillSuggestions(kPageID, false, field));
}
-TEST_F(AutoFillManagerTest, GetCombinedAutoFillAndAutocompleteSuggestions) {
+TEST_F(AutoFillManagerTest,
+ SKIP_BRANDED(GetCombinedAutoFillAndAutocompleteSuggestions)) {
FormData form;
CreateTestFormData(&form);
@@ -599,7 +609,7 @@
EXPECT_EQ(string16(), labels[3]);
}
-TEST_F(AutoFillManagerTest, GetFieldSuggestionsFormIsAutoFilled) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(GetFieldSuggestionsFormIsAutoFilled)) {
FormData form;
CreateTestFormData(&form);
@@ -635,7 +645,8 @@
EXPECT_EQ(string16(), labels[1]);
}
-TEST_F(AutoFillManagerTest, GetFieldSuggestionsForAutocompleteOnly) {
+TEST_F(AutoFillManagerTest,
+ SKIP_BRANDED(GetFieldSuggestionsForAutocompleteOnly)) {
FormData form;
CreateTestFormData(&form);
@@ -671,7 +682,8 @@
ASSERT_EQ(0U, labels.size());
}
-TEST_F(AutoFillManagerTest, GetFieldSuggestionsWithDuplicateValues) {
+TEST_F(AutoFillManagerTest,
+ SKIP_BRANDED(GetFieldSuggestionsWithDuplicateValues)) {
FormData form;
CreateTestFormData(&form);
@@ -713,7 +725,7 @@
EXPECT_EQ(string16(), labels[1]);
}
-TEST_F(AutoFillManagerTest, FillCreditCardForm) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(FillCreditCardForm)) {
FormData form;
CreateTestFormDataBilling(&form);
@@ -790,7 +802,7 @@
EXPECT_TRUE(field.StrictlyEqualsHack(results.fields[14]));
}
-TEST_F(AutoFillManagerTest, FillNonBillingFormSemicolon) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(FillNonBillingFormSemicolon)) {
// |profile| will be owned by the mock PersonalDataManager.
AutoFillProfile* profile = new AutoFillProfile;
autofill_unittest::SetProfileInfo(profile, "Home; 8765", "Joe", "", "Ely",
@@ -864,7 +876,7 @@
EXPECT_TRUE(field.StrictlyEqualsHack(results.fields[10]));
}
-TEST_F(AutoFillManagerTest, FillBillFormSemicolon) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(FillBillFormSemicolon)) {
// |profile| will be owned by the mock PersonalDataManager.
AutoFillProfile* profile = new AutoFillProfile;
autofill_unittest::SetProfileInfo(profile, "Home; 8765", "Joe", "", "Ely",
@@ -948,7 +960,7 @@
EXPECT_TRUE(field.StrictlyEqualsHack(results.fields[14]));
}
-TEST_F(AutoFillManagerTest, FillPhoneNumber) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(FillPhoneNumber)) {
FormData form;
form.name = ASCIIToUTF16("MyPhoneForm");
@@ -1021,7 +1033,7 @@
work_profile->SetInfo(phone_type, saved_phone);
}
-TEST_F(AutoFillManagerTest, FormChangesRemoveField) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(FormChangesRemoveField)) {
FormData form;
form.name = ASCIIToUTF16("MyForm");
form.method = ASCIIToUTF16("POST");
@@ -1088,7 +1100,7 @@
EXPECT_TRUE(field.StrictlyEqualsHack(results.fields[3]));
}
-TEST_F(AutoFillManagerTest, FormChangesAddField) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(FormChangesAddField)) {
FormData form;
form.name = ASCIIToUTF16("MyForm");
form.method = ASCIIToUTF16("POST");
@@ -1158,7 +1170,7 @@
EXPECT_TRUE(field.StrictlyEqualsHack(results.fields[4]));
}
-TEST_F(AutoFillManagerTest, HiddenFields) {
+TEST_F(AutoFillManagerTest, SKIP_BRANDED(HiddenFields)) {
FormData form;
form.name = ASCIIToUTF16("MyForm");
form.method = ASCIIToUTF16("POST");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698