Disable AutoFillManagerTest tests in branded builds....

Disable AutoFillManagerTest tests in branded builds.

BUG=50537
TEST=Should not crash on official builds.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54054

[rohitrao (ping after 24h), 2010-07-28 20:25:11]

Per IRC and IM conversations, I think the best thing to do is disable these
tests in branded builds.  I will check the trybot output to make sure they still
run in non-branded builds.

I think the underlying bug should be P1 and releaseblock-something, since
testing autofill request code seems important.

Does anyone prefer the code in patchset #2?  I strongly prefer the MAYBE_
syntax, even though there is a large number of tests.

[James Hawkins, 2010-07-28 20:29:38]

http://codereview.chromium.org/3032034/diff/6001/7001
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/3032034/diff/6001/7001#newcode282
chrome/browser/autofill/autofill_manager_unittest.cc:282: // TODO(jhawkins): All
of these tests crash in official
TODO(georgey).

http://codereview.chromium.org/3032034/diff/6001/7001#newcode286
chrome/browser/autofill/autofill_manager_unittest.cc:286: #define
MAYBE_GetProfileSuggestionsEmptyValue \
Why not use SKIP_?

#define SKIP(test) DISABLED_##test

[rohitrao (ping after 24h), 2010-07-28 20:45:52]

Is patchset 4 what you had in mind?

[James Hawkins, 2010-07-28 21:29:58]

#4 LGTM with comment change.

http://codereview.chromium.org/3032034/diff/9001/10001
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/3032034/diff/9001/10001#newcode282
chrome/browser/autofill/autofill_manager_unittest.cc:282: // TODO(jhawkins): All
of these tests crash in official
TODO(georgey)