Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 3032030: Implement accurate seeking by decoding audio/video until we reach our desired timestamp. (Closed)

Created:
10 years, 5 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, scherkus (not reviewing), fbarchard, awong, Alpha Left Google
Visibility:
Public.

Description

Implement accurate seeking by decoding audio/video until we reach our desired timestamp. This fixes a host of seeking, synchronization and layout test issues but does incur a CPU performance hit while seeking. In the worst case a seek could take quite some time if the content was high resolution H.264 and we attempted to seek to right before a keyframe. We'll see how people like the new behaviour and back this change out if needed. BUG=48984 TEST=layout tests, media_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53872

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M media/filters/audio_renderer_base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/audio_renderer_base.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M media/filters/video_renderer_base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/video_renderer_base.cc View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alpha Left Google
LGTM after a small nit. http://codereview.chromium.org/3032030/diff/1/3 File media/filters/audio_renderer_base.cc (right): http://codereview.chromium.org/3032030/diff/1/3#newcode156 media/filters/audio_renderer_base.cc:156: (buffer_in->GetTimestamp() + buffer_in->GetDuration()) < ...
10 years, 5 months ago (2010-07-27 21:21:49 UTC) #1
scherkus (not reviewing)
10 years, 5 months ago (2010-07-27 21:57:47 UTC) #2
Will check in after try servers etc....

http://codereview.chromium.org/3032030/diff/1/3
File media/filters/audio_renderer_base.cc (right):

http://codereview.chromium.org/3032030/diff/1/3#newcode156
media/filters/audio_renderer_base.cc:156: (buffer_in->GetTimestamp() +
buffer_in->GetDuration()) < seek_timestamp_) {
On 2010/07/27 21:21:49, Alpha wrote:
> nit: 80 chars
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698