Issue 3032019: Add flag to cros_mark_as_stable to specify tracking_branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3032019: Add flag to cros_mark_as_stable to specify tracking_branch. (Closed)

Created:
10 years, 5 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, Jason Glasgow

Base URL:
ssh://git@chromiumos-git//crosutils.git

Visibility:
Public.

Description

Add flag to cros_mark_as_stable to specify tracking_branch. TEST=Ran using default option and then tried -t chromiumorg/master and saw a correct failure since I don't have that branch to track against.

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	cros_mark_as_stable.py	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

LGTM Now repo workflow users can use it! Do the other cros_mark tools need this?

10 years, 5 months ago (2010-07-23 18:16:22 UTC) #2

sosa

10 years, 5 months ago (2010-07-23 18:28:57 UTC) #3

No, the other relevant script cros_mark_all should not be used by
developers (mainly intended as a stop gap for the buildbot / me).  It
goes through all the repos and updates all ebuilds that have
mismatching CROS_WORKON_COMMIT's to the heads of their corresponding
git repos.  So developers should not be using this otherwise it is
likely they will commit a world-ending CL like mine - my CL was just
the direct output of that script.

On Fri, Jul 23, 2010 at 11:16 AM,  <wad@chromium.org> wrote:
> LGTM
>
> Now repo workflow users can use it!  Do the other cros_mark tools need this?
>
> http://codereview.chromium.org/3032019/show
>

Expand Messages | Collapse Messages