Issue 3032004: Link libcrash conditionally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3032004: Link libcrash conditionally. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/metrics.git

Visibility:
Public.

Description

Link libcrash conditionally. This enables building metrics for the host thus enabling using metrics in the current update_engine without breaking the host dev flow. BUG=4852 TEST=emerged with and without USE=-crash

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Makefile	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 5 months ago (2010-07-19 17:53:08 UTC) #2

LGTM

On Fri, Jul 16, 2010 at 1:02 PM,  <petkov@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Link libcrash conditionally.
>
> This enables building metrics for the host thus enabling using metrics
> in the current update_engine without breaking the host dev flow.
>
> BUG=4852
> TEST=emerged with and without USE=-crash
>
> Please review this at http://codereview.chromium.org/3032004/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/metrics.git
>
> Affected files:
>  M Makefile
>
>
> Index: Makefile
> diff --git a/Makefile b/Makefile
> index
>
480da220ae6ff77b4e31bb819764807e96cdae00..f3dddd87329da664907ff67b482839aca593d66a
> 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -18,6 +18,8 @@ SHAREDLIB = libmetrics.so
>  LIB_TEST = metrics_library_test
>  COUNTER_TEST = counter_test
>
> +LCRASH ?= -lcrash
> +
>  TESTCOUNTER_OBJS = \
>        counter.o \
>        counter_test.o
> @@ -53,7 +55,7 @@ $(COUNTER_TEST): $(TESTCOUNTER_OBJS)
>        $(CXX) -o $@ $^ $(TESTCOUNTER_LIBS)
>
>  $(DAEMON): $(DAEMON_OBJS) $(SHAREDLIB)
> -       $(CXX) -o $@ $^ $(DAEMON_LDFLAGS) -lcrash
> +       $(CXX) -o $@ $^ $(DAEMON_LDFLAGS) $(LCRASH)
>
>  $(DAEMON_TEST): $(TESTDAEMON_OBJS)
>        $(CXX) -o $@ $^ $(DAEMON_LDFLAGS) $(TESTDAEMON_LIBS)
>
>
>

Expand Messages | Collapse Messages