Issue 3032001: Make UpgradeDetector work on the Mac

Issue 3032001: Make UpgradeDetector work on the Mac (Closed)

Created:
10 years, 5 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make UpgradeDetector work on the Mac. This is the backend work only. There's no UI yet. BUG=45147 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52524

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -27 lines)			Patch
M	chrome/browser/cocoa/keystone_glue.h	View		2 chunks	+18 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/keystone_glue.mm	View		5 chunks	+26 lines, -4 lines	0 comments	Download
M	chrome/browser/upgrade_detector.cc	View	1	6 chunks	+27 lines, -18 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/chrome_installer_util.gypi	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

http://codereview.chromium.org/3032001/diff/4001/5001 File chrome/browser/cocoa/keystone_glue.h (right): http://codereview.chromium.org/3032001/diff/4001/5001#newcode14 chrome/browser/cocoa/keystone_glue.h:14: #import "base/scoped_nsobject.h" Is this needed? http://codereview.chromium.org/3032001/diff/4001/5003 File chrome/browser/upgrade_detector.cc (right): ...

10 years, 5 months ago (2010-07-15 19:20:58 UTC) #2

Mark Mentovai

Recommented, too. http://codereview.chromium.org/3032001/diff/4001/5001 File chrome/browser/cocoa/keystone_glue.h (right): http://codereview.chromium.org/3032001/diff/4001/5001#newcode14 chrome/browser/cocoa/keystone_glue.h:14: #import "base/scoped_nsobject.h" rsesek wrote: > Is this ...

10 years, 5 months ago (2010-07-15 19:56:14 UTC) #3

Robert Sesek

LGTM http://codereview.chromium.org/3032001/diff/4001/5001 File chrome/browser/cocoa/keystone_glue.h (right): http://codereview.chromium.org/3032001/diff/4001/5001#newcode14 chrome/browser/cocoa/keystone_glue.h:14: #import "base/scoped_nsobject.h" On 2010/07/15 19:56:14, Mark Mentovai wrote: ...

10 years, 5 months ago (2010-07-15 19:58:09 UTC) #4

Mark Mentovai

10 years, 5 months ago (2010-07-15 19:59:09 UTC) #5

> http://codereview.chromium.org/3032001/diff/4001/5001#newcode14
> chrome/browser/cocoa/keystone_glue.h:14: #import
> "base/scoped_nsobject.h"
> On 2010/07/15 19:56:14, Mark Mentovai wrote:
>>
>> rsesek wrote:
>> > Is this needed?
>
>> See recentNotification_, line 91.
>
> Ah; not part of the diff.

Allays.

Expand Messages | Collapse Messages