Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: sync_build_test.sh

Issue 3031056: Moved running unit tests to occur after building Chrome browser in sync_build_test.sh. (Closed) Base URL: ssh://gitrw.chromium.org/crosutils.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync_build_test.sh
diff --git a/sync_build_test.sh b/sync_build_test.sh
index 99f19a5efbe472a6d7e685b4f4eb2ef16fc0507e..ccb151470b0d87b23b33f2c5bbf63fe66538597f 100755
--- a/sync_build_test.sh
+++ b/sync_build_test.sh
@@ -533,11 +533,6 @@ function main() {
./build_packages "${board_param}" \
${jobs_param} ${withdev_param} ${build_autotest_param} \
${pkg_param}
-
- if [[ "${FLAGS_board}" == "x86-generic" ]]; then
- run_phase_in_chroot "Running unit tests" ./cros_run_unit_tests \
- ${board_param}
- fi
fi
if [[ ${FLAGS_chrome_root} ]]; then
@@ -546,6 +541,12 @@ function main() {
CHROME_ORIGIN=LOCAL_SOURCE emerge-${FLAGS_board} chromeos-chrome
fi
+ if [[ ${FLAGS_unittest} -eq ${FLAGS_TRUE} ]] && [[ "${FLAGS_board}" == \
+ "x86-generic" ]] ; then
+ run_phase_in_chroot "Running unit tests" ./cros_run_unit_tests \
+ ${board_param}
+ fi
+
if [[ ${FLAGS_master} -eq ${FLAGS_TRUE} ]]; then
chdir_relative src/scripts
if [[ -n "${FLAGS_chronos_passwd}" ]]; then
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698