Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10244)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome_frame/vtable_patch_manager.cc

Issue 3031009: A different approach to avoid crashes in buggy 3rd party BHOs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/vtable_patch_manager.cc
===================================================================
--- chrome_frame/vtable_patch_manager.cc (revision 53172)
+++ chrome_frame/vtable_patch_manager.cc (working copy)
@@ -4,9 +4,10 @@
#include "chrome_frame/vtable_patch_manager.h"
-#include <algorithm>
#include <atlcomcli.h>
+#include <algorithm>
+
#include "base/atomicops.h"
#include "base/lock.h"
#include "base/logging.h"
@@ -90,7 +91,7 @@
FunctionStub* stub = NULL;
#ifndef NDEBUG
- FunctionStub::FromCode(original_fn);
+ stub = FunctionStub::FromCode(original_fn);
if (stub != NULL) {
DLOG(ERROR) << "attempt to patch a function that's already patched";
DCHECK(stub->destination_function() ==
« no previous file with comments | « chrome_frame/utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698