Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome_frame/bind_context_info.cc

Issue 3031009: A different approach to avoid crashes in buggy 3rd party BHOs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/buggy_bho_handling.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/bind_context_info.cc
===================================================================
--- chrome_frame/bind_context_info.cc (revision 53172)
+++ chrome_frame/bind_context_info.cc (working copy)
@@ -47,9 +47,10 @@
hr = internal.QueryFrom(context);
DCHECK(SUCCEEDED(hr));
if (SUCCEEDED(hr)) {
- BindContextInfo* ret = NULL;
hr = internal->GetCppObject(reinterpret_cast<void**>(info));
DCHECK_EQ(hr, S_OK);
+ DLOG_IF(ERROR, *info != static_cast<BindContextInfo*>(internal.get()))
+ << "marshalling took place!";
}
} else {
DCHECK(FAILED(hr));
« no previous file with comments | « no previous file | chrome_frame/buggy_bho_handling.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698