A different approach to avoid crashes in buggy 3rd party BHOs.

chrome_frame/chrome_active_document.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of ChromeActiveDocument
 #include "chrome_frame/chrome_active_document.h"
 
 #include <hlink.h>
 #include <htiface.h>
 #include <initguid.h>
 #include <mshtmcid.h>
 #include <shdeprecated.h>
 #include <shlguid.h>
 #include <shobjidl.h>
 #include <tlogstg.h>
 #include <urlmon.h>
 #include <wininet.h>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
-#include "base/file_version_info.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/registry.h"
 #include "base/scoped_variant_win.h"
 #include "base/string_tokenizer.h"
 #include "base/string_util.h"
 #include "base/thread.h"
 #include "base/thread_local.h"
 #include "base/trace_event.h"
 
 #include "grit/generated_resources.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/navigation_types.h"
 #include "chrome/test/automation/browser_proxy.h"
 #include "chrome/test/automation/tab_proxy.h"
 #include "chrome_frame/bho.h"
 #include "chrome_frame/bind_context_info.h"
+#include "chrome_frame/buggy_bho_handling.h"
 #include "chrome_frame/crash_reporting/crash_metrics.h"
 #include "chrome_frame/utils.h"
 
 const wchar_t kChromeAttachExternalTabPrefix[] = L"attach_external_tab";
 
 static const wchar_t kUseChromeNetworking[] = L"UseChromeNetworking";
 static const wchar_t kHandleTopLevelRequests[] = L"HandleTopLevelRequests";
 
 DEFINE_GUID(CGID_DocHostCmdPriv, 0x000214D4L, 0, 0, 0xC0, 0, 0, 0, 0, 0, 0,
             0x46);
 
-
 base::ThreadLocalPointer<ChromeActiveDocument> g_active_doc_cache;
 
 bool g_first_launch_by_process_ = true;
 
 const DWORD kIEEncodingIdArray[] = {
 #define DEFINE_ENCODING_ID_ARRAY(encoding_name, id, chrome_name) encoding_name,
   INTERNAL_IE_ENCODINGMENU_IDS(DEFINE_ENCODING_ID_ARRAY)
 #undef DEFINE_ENCODING_ID_ARRAY
   0  // The Last data must be 0 to indicate the end of the encoding id array.
 };
@@ skipping 653 matching lines @@
        StartsWith(static_cast<BSTR>(url_), kChromeAttachExternalTabPrefix,
                   false);
 
   if (new_navigation_info.url.is_valid())
     url_.Allocate(UTF8ToWide(new_navigation_info.url.spec()).c_str());
 
   if (is_internal_navigation) {
     ScopedComPtr<IDocObjectService> doc_object_svc;
     ScopedComPtr<IWebBrowserEventsService> web_browser_events_svc;
 
+    buggy_bho::BuggyBhoTls bad_bho_tls;
+    if (GetConfigBool(true, kEnableBuggyBhoIntercept)) {
+      ScopedComPtr<IWebBrowser2> wb2;
+      DoQueryService(SID_SWebBrowserApp, m_spClientSite, wb2.Receive());
+      if (wb2) {
+        buggy_bho::BuggyBhoTls::PatchBuggyBHOs(wb2);
+      }
+    }
+
     DoQueryService(__uuidof(web_browser_events_svc), m_spClientSite,
                    web_browser_events_svc.Receive());
 
     if (!web_browser_events_svc.get()) {
       DoQueryService(SID_SShellBrowser, m_spClientSite,
                      doc_object_svc.Receive());
     }
 
     // web_browser_events_svc can be NULL on IE6.
     if (web_browser_events_svc) {
@@ skipping 20 matching lines @@
            internal_navigation.AsInput(), NULL);
 
     // We no longer need to lie to IE. If we lie persistently to IE, then
     // IE reuses us for new navigations.
     IEExec(&CGID_DocHostCmdPriv, DOCHOST_DOCCANNAVIGATE, 0, NULL, NULL);
 
     if (doc_object_svc) {
       // Now call the FireNavigateCompleteEvent which makes IE update the text
       // in the address-bar.
       doc_object_svc->FireNavigateComplete2(this, 0);
-      if (ShouldFireDocumentComplete())
-        doc_object_svc->FireDocumentComplete(this, 0);
+      doc_object_svc->FireDocumentComplete(this, 0);
     } else if (web_browser_events_svc) {
       web_browser_events_svc->FireNavigateComplete2Event();
-      if (ShouldFireDocumentComplete())
-        web_browser_events_svc->FireDocumentCompleteEvent();
+      web_browser_events_svc->FireDocumentCompleteEvent();
     }
   }
 
   if (is_title_changed) {
     ScopedVariant title(new_navigation_info.title.c_str());
     IEExec(NULL, OLECMDID_SETTITLE, OLECMDEXECOPT_DONTPROMPTUSER,
            title.AsInput(), NULL);
   }
 
   // It is important that we only update the navigation_info_ after we have
@@ skipping 474 matching lines @@
   DCHECK(shell_browser.get() != NULL);
   ScopedComPtr<ITridentService2> trident_services;
   trident_services.QueryFrom(shell_browser);
   if (trident_services)
     trident_services->FirePrivacyImpactedStateChange(wparam);
   else
     NOTREACHED() << "Failed to retrieve IWebBrowser2 interface.";
   return 0;
 }
 
-namespace {
-struct ModuleAndVersion {
-  const char* module_name_;
-  const uint32 major_version_;
-  const uint32 minor_version_;
-};
-}  // end namespace
-
-// static
-bool ChromeActiveDocument::ShouldFireDocumentComplete() {
-  typedef enum ModuleCheckResult {
-    CHECK_NOT_DONE,
-    DOCUMENT_COMPLETE_OK,
-    DOCUMENT_COMPLETE_NOT_OK
-  };
-
-  static ModuleCheckResult results = CHECK_NOT_DONE;
-
-  if (results == CHECK_NOT_DONE) {
-    // These modules are missing some checks in their DocumentComplete
-    // implementation that causes a crash.
-    static const ModuleAndVersion buggy_modules[] = {
-      { "askbar.dll", 4, 1 },  // biggest troublemaker: 4.1.0.5.
-      { "gbieh.dll", 3, 8 },  // biggest troublemaker: 3.8.14.12
-      { "gbiehcef.dll", 3, 8 },  // biggest troublemaker: 3.8.11.23
-      { "gbiehUni.dll", 3, 8 },  // Another Banco DLL.
-    };
-
-    for (size_t i = 0; results == CHECK_NOT_DONE &&
-                       i < arraysize(buggy_modules); ++i) {
-      const ModuleAndVersion& module = buggy_modules[i];
-      HMODULE mod = ::GetModuleHandleA(module.module_name_);
-      if (mod) {
-        wchar_t path[MAX_PATH * 2] = {0};
-        ::GetModuleFileNameW(mod, path, arraysize(path));
-        scoped_ptr<FileVersionInfo> version_info(
-            FileVersionInfo::CreateFileVersionInfo(FilePath(path)));
-        DCHECK(version_info.get());
-        if (version_info.get()) {
-          uint32 major = 0, minor = 0;
-          if (!ParseVersion(version_info->file_version(), &major, &minor))
-            ParseVersion(version_info->product_version(), &major, &minor);
-          if (major < module.major_version_ ||
-              (major == module.major_version_ &&
-               minor <= module.minor_version_)) {
-            DLOG(WARNING) << "Buggy module found: " << module.module_name_;
-            results = DOCUMENT_COMPLETE_NOT_OK;
-          }
-        }
-      }
-    }
-
-    if (results == CHECK_NOT_DONE)
-      results = DOCUMENT_COMPLETE_OK;
-  }
-
-  return results == DOCUMENT_COMPLETE_OK;
-}
-