Issue 303034: X64/Win64: Alternative implementation of fmod in general.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303034: X64/Win64: Alternative implementation of fmod in general. (Closed)

Created:
11 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

X64/Win64: Alternative implementation of fmod in general.

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+226 lines, -28 lines)			Patch
M	src/conversions.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/conversions.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/conversions-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform-nullos.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/platform-posix.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	2 chunks	+9 lines, -12 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+89 lines, -0 lines	1 comment	Download
M	src/x64/disasm-x64.cc	View	1 chunk	+14 lines, -4 lines	0 comments	Download
M	test/mjsunit/div-mod.js	View	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Mads, is this an appropriate way to create new assembler code, or should I just ...

11 years, 2 months ago (2009-10-22 11:15:20 UTC) #1

William Hesse

11 years, 2 months ago (2009-10-23 07:45:14 UTC) #3

LGTM.

http://codereview.chromium.org/303034/diff/1/12
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/303034/diff/1/12#newcode7712
Line 7712: 
Put a comment in here that no relocatable addresses are used here, because only
the first two stages of creating a relocatable code object are run?  I.E. that
we are creating position-independent code?

Expand Messages | Collapse Messages