Refactor: Change the interface HostResolver::DisableIPv6() to HostResolver::SetDefaultA...

Refactor: Change the interface from HostResolver::DisableIPv6() to HostResolver::SetDefaultAddressFamily(), to make it more general.

This came up in a codereview comment, but was after I had checked in.

Comitted r30063.

[wtc, 2009-10-22 22:24:20]

LGTM.

http://codereview.chromium.org/303026/diff/2001/2002
File net/base/host_resolver.h (right):

http://codereview.chromium.org/303026/diff/2001/2002#newcode152
Line 152: // unspecified. This can be used to disable IPV6.
For political correctness, let's say "disable IPv4 or IPv6" :)

[eroman, 2009-10-22 23:23:07]

http://codereview.chromium.org/303026/diff/2001/2002
File net/base/host_resolver.h (right):

http://codereview.chromium.org/303026/diff/2001/2002#newcode152
Line 152: // unspecified. This can be used to disable IPV6.
On 2009/10/22 22:24:20, wtc wrote:
> For political correctness, let's say "disable IPv4 or IPv6" :)

Done.

Good call.

(In fact, the main purpose of this change is to make the interface a little less
obnoxious by not singling out IPv6, but having it be more general)

The wording now reads:

// Sets the default AddressFamily to use when requests have left it
// unspecified. For example, this could be used to restrict resolution
// results to AF_INET by passing in ADDRESS_FAMILY_IPV4.

[Lorenzo Colitti, 2009-10-23 05:02:02]

LGTM

Looks much nicer now, thanks! I still don't particularly like the command-line
flag, but if you feel it will help developers during testing then I suppose it's
OK.

[wtc, 2009-10-23 17:16:17]

I don't like the command-line option either.  We should
add a comment to say that it should only be used for
diagnosing problems that may be caused by IPv6 host name
resolution, or just remove it until the need arises.

[eroman, 2009-10-23 20:56:59]

On 2009/10/23 17:16:17, wtc wrote:
> I don't like the command-line option either.  We should
> add a comment to say that it should only be used for
> diagnosing problems that may be caused by IPv6 host name
> resolution, or just remove it until the need arises.

Done, added this comment above the flag:

// Don't resolve hostnames to IPv6 addresses. This can be used when debugging
// issues relating to IPv6, but shouldn't otherwise be needed. Be sure to
// file bugs if something isn't working properly in the presence of IPv6.