Disable IPv6 results for the PAC bindings:...

Disable IPv6 results for the PAC bindings:
  myIpAddress()
  dnsResolve()
  isResolvable()

This makes us behave more like IE and less like Firefox for scripts where IPv6 addresses are not expected.

BUG=24641
TEST=ProxyResolverJSBindingsTest.DontUseIPv6

Committed in r29804.

[eroman, 2009-10-21 20:54:04]

This is really just a 4 line change (proxy_resolver_js_bindings_unittest.cc).

All of the other deltas are for the unittest.

[eroman, 2009-10-21 20:54:48]

>  This is really just a 4 line change (proxy_resolver_js_bindings_unittest.cc).

Er, I meant proxy_resolver_js_bindings.cc

[darin (slow to review), 2009-10-22 15:25:59]

LGTM

[wtc, 2009-10-22 21:53:54]

LGTM.  It's not clear how you took care of isResolvable().

http://codereview.chromium.org/303022/diff/4001/4005
File net/base/mock_host_resolver.cc (right):

http://codereview.chromium.org/303022/diff/4001/4005#newcode151
Line 151: 
Nit: delete one blank line here.

http://codereview.chromium.org/303022/diff/4001/4005#newcode155
Line 155: ADDRESS_FAMILY_UNSPECIFIED, ipv6_literal, 0);
Why do you pass ADDRESS_FAMILY_UNSPECIFIED here?
I was expecting ADDRESS_FAMILY_IPV6.

http://codereview.chromium.org/303022/diff/4001/4004
File net/base/mock_host_resolver.h (right):

http://codereview.chromium.org/303022/diff/4001/4004#newcode106
Line 106: void AddRuleForFamily(const std::string& host_pattern,
Nit: rename this AddRuleForAddressFamily.

Are you surprised that I suggested a longer function name? :-)

http://codereview.chromium.org/303022/diff/4001/4002
File net/proxy/proxy_resolver_js_bindings.cc (right):

http://codereview.chromium.org/303022/diff/4001/4002#newcode113
Line 113: // Disable IPv6 results, see http://crbug.com/24641 for motivation.
The motivation is short (dnsResolve is IPv4 only).  I'd just
state it here rather than forcing the reader to read a long
bug report.

http://codereview.chromium.org/303022/diff/4001/4002#newcode116
Line 116: ADDRESS_FAMILY_IPV4_ONLY,
Nit: do we really need _ONLY in the enum constant name?

Except for ADDRESS_FAMILY_UNSPECIFIED, all the
ADDRESS_FAMILY_ enum constants specify a single address
family.  So _ONLY is implied.

[eroman, 2009-10-22 22:06:21]

> LGTM.  It's not clear how you took care of isResolvable().

isResolvable() is implemented in terms of dnsResolve(), so we get it for free:

function isResolvable(host) {
    var ip = dnsResolve(host);
    return (ip != null);
}

I will address your other comments as a separate CL (since this is already
committed).