Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 303021: Added support for array literals to the toplevel compiler. They are... (Closed)

Created:
11 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added support for array literals to the toplevel compiler. They are currently compiled the same as with the optimizing compiler: they are cloned from a boilerplate object and the boilerplate objects are lazily constructed. Also changed argument pushing on ARM to use stm (store multiple), which required changing the order of arguments to the runtime functions DeclareGlobals and NewClosure. They were only used from generated code. Finally, changed the toplevel code generator so that stack pops to discard a temporary became addition to the stack pointer on ia32 and x64. Committed: http://code.google.com/p/v8/source/detail?r=3110

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -50 lines) Patch
M src/arm/codegen-arm.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/arm/fast-codegen-arm.cc View 6 chunks +82 lines, -11 lines 0 comments Download
M src/compiler.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/fast-codegen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 7 chunks +76 lines, -5 lines 0 comments Download
M src/runtime.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 7 chunks +76 lines, -5 lines 0 comments Download
M test/mjsunit/compiler/literals.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
I plan to add tests before submitting (tomorrow).
11 years, 2 months ago (2009-10-21 15:55:23 UTC) #1
fschneider
LGTM.
11 years, 2 months ago (2009-10-22 09:00:50 UTC) #2
William Hesse
11 years, 2 months ago (2009-10-22 09:33:29 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698