Issue 303018: Simplify GetLinuxDistro() for Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303018: Simplify GetLinuxDistro() for Chrome OS. (Closed)

Created:
11 years, 2 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Simplify GetLinuxDistro() for Chrome OS. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29682

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	base/linux_util.cc	View	1	5 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

http://codereview.chromium.org/303018/diff/1/2 File base/linux_util.cc (right): http://codereview.chromium.org/303018/diff/1/2#newcode126 Line 126: #endif I think this logic is backwards, no? ...

11 years, 2 months ago (2009-10-21 15:03:58 UTC) #2

Lei Zhang

http://codereview.chromium.org/303018/diff/1/2 File base/linux_util.cc (right): http://codereview.chromium.org/303018/diff/1/2#newcode126 Line 126: #endif On 2009/10/21 15:03:58, cmasone wrote: > I ...

11 years, 2 months ago (2009-10-21 18:22:42 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 303018: Simplify GetLinuxDistro() for Chrome OS. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages