Issue 3030042: New translate tests for pyauto.py

Issue 3030042: New translate tests for pyauto.py (Closed)

Created:
10 years, 4 months ago by Alyssa

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

New translate tests for pyauto.py This also includes a change to WaitUntilTranslateComplete. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55070

Patch Set 3 : Adding corpora #

Created: 10 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10297 lines, -26 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View		1 chunk	+16 lines, -14 lines	0 comments	Download
A	chrome/test/data/translate/ar/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ar/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ar/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ar/google_news.html	View		1 chunk	+361 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/de/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/de/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/de/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/de/google_news.html	View		1 chunk	+402 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/el/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/el/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/el/google_maps.html	View		1 chunk	+65 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/el/google_news.html	View		1 chunk	+382 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/es/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/es/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/es/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/es/google_news.html	View		1 chunk	+416 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/fi/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/fi/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/fi/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/fr/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/fr/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/fr/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/fr/google_news.html	View		1 chunk	+402 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/he/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/he/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/he/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/hi/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/hi/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/hi/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/hi/google_news.html	View		1 chunk	+326 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/it/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/it/google_maps.html	View		1 chunk	+65 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/it/google_news.html	View		1 chunk	+394 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ja/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ja/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ja/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ja/google_news.html	View		1 chunk	+436 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ko/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ko/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ko/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ko/google_news.html	View		1 chunk	+430 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/nl/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/nl/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/nl/google_maps.html	View		1 chunk	+65 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/nl/google_news.html	View		1 chunk	+397 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/notranslate_meta_tag.html	View	2	1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/pl/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/pl/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/pl/google_maps.html	View		1 chunk	+65 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/pl/google_news.html	View		1 chunk	+325 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/pt/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/pt/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/pt/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ru/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ru/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ru/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/ru/google_news.html	View		1 chunk	+389 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/sv/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/sv/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/sv/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/sv/google_news.html	View		1 chunk	+398 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/th/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/th/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/th/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/th/google_news.html	View		1 chunk	+45 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/tr/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/tr/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/tr/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/tr/google_news.html	View		1 chunk	+325 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/zh-CN/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/zh-CN/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/zh-CN/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/zh-CN/google_news.html	View		1 chunk	+863 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/zh-TW/google.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/zh-TW/google_images.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/zh-TW/google_maps.html	View		1 chunk	+168 lines, -0 lines	0 comments	Download
A	chrome/test/data/translate/zh-TW/google_news.html	View		1 chunk	+433 lines, -0 lines	0 comments	Download
M	chrome/test/functional/PYAUTO_TESTS	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/functional/translate.py	View	1 2	9 chunks	+224 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Alyssa

http://codereview.chromium.org/3030042/diff/5001/6001 File chrome/browser/automation/automation_provider.cc (right): http://codereview.chromium.org/3030042/diff/5001/6001#newcode2890 chrome/browser/automation/automation_provider.cc:2890: if (translate_bar->type() == TranslateInfoBarDelegate::TRANSLATING) { The translation_pending() state wasn't ...

10 years, 4 months ago (2010-08-04 18:42:47 UTC) #1

Nirnimesh

1. Let's replace all http:// usage with file:// usage wherever possible. file:// urls load much ...

10 years, 4 months ago (2010-08-04 20:45:17 UTC) #2

Alyssa

http://codereview.chromium.org/3030042/diff/5001/6002 File chrome/test/data/notranslate_meta_tag.html (right): http://codereview.chromium.org/3030042/diff/5001/6002#newcode1 chrome/test/data/notranslate_meta_tag.html:1: <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" On 2010/08/04 20:45:18, ...

10 years, 4 months ago (2010-08-04 23:32:07 UTC) #3

http://codereview.chromium.org/3030042/diff/5001/6002
File chrome/test/data/notranslate_meta_tag.html (right):

http://codereview.chromium.org/3030042/diff/5001/6002#newcode1
chrome/test/data/notranslate_meta_tag.html:1: <!DOCTYPE html PUBLIC "-//W3C//DTD
HTML 4.01//EN"
On 2010/08/04 20:45:18, Nirnimesh wrote:
> We should not checkin yahoo pages!!
> Let's use a google page.
> Also, put all data in chrome/test/data/translate

Ah, sorry about that. Changed to a file.

http://codereview.chromium.org/3030042/diff/5001/6004
File chrome/test/functional/translate.py (right):

http://codereview.chromium.org/3030042/diff/5001/6004#newcode153
chrome/test/functional/translate.py:153:
self.NavigateToURL('https://www.sourceforge.net')
On 2010/08/04 20:45:18, Nirnimesh wrote:
> add comment that this is a page with ssl error

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode165
chrome/test/functional/translate.py:165:
self.NavigateToURL('https://www.google.com')
On 2010/08/04 20:45:18, Nirnimesh wrote:
> can we use a file:// url?
> file:// urls load faster on the bots

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode177
chrome/test/functional/translate.py:177: self._AssertTranslateWorks(url,
self.spanish)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> why are we using self.spanish here but 'es' just 2 lines above.
> Make it consistent

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode180
chrome/test/functional/translate.py:180: """Test that the translate bar is not
shown on pages of a language after
On 2010/08/04 20:45:18, Nirnimesh wrote:
> make it brief: Verify no translate bar for blacklisted language

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode187
chrome/test/functional/translate.py:187: self.WaitForInfobarCount(0)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> The count was already 0 before. Is this enough?
> We should first have a non-zero infobar (maybe another language, so that it
> actually shows up), the navigate to spanish page and verify that it doesn't
show
> up

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode194
chrome/test/functional/translate.py:194: """Test Translate bar is not visible on
pages with the no translate meta
On 2010/08/04 20:45:18, Nirnimesh wrote:
> make it brief: test "notranslate" meta tag 

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode204
chrome/test/functional/translate.py:204: """Test to toggling the 'Always
Translate' option."""
On 2010/08/04 20:45:18, Nirnimesh wrote:
> s/toggling/toggle/

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode205
chrome/test/functional/translate.py:205:
self._NavigateAndWaitForBar('http://www.vivaaerobus.com/')
On 2010/08/04 20:45:18, Nirnimesh wrote:
> what url is this? Or test will fail if this URL is down
> 
> let's use one from our collection

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode206
chrome/test/functional/translate.py:206: # Select 'Always Translate'.
On 2010/08/04 20:45:18, Nirnimesh wrote:
> assert the default state first

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode214
chrome/test/functional/translate.py:214: success =
self.WaitUntilTranslateComplete()
On 2010/08/04 20:45:18, Nirnimesh wrote:
> add comment explaining why you need this

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode215
chrome/test/functional/translate.py:215: if not success:
On 2010/08/04 20:45:18, Nirnimesh wrote:
> if not success, this test should fail right?

Not necessarily. It's the same reason we click translate until success on all of
the others. Sometimes the translation just fails and we don't want the tests to
be flaky.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode241
chrome/test/functional/translate.py:241: translate_success =
self.WaitUntilTranslateComplete()
On 2010/08/04 20:45:18, Nirnimesh wrote:
> assert this?

I decided to assert this differently. See comments in code. Is this clear enough
and okay?

http://codereview.chromium.org/3030042/diff/5001/6004#newcode243
chrome/test/functional/translate.py:243: translate_info
On 2010/08/04 20:45:18, Nirnimesh wrote:
> ??

Removed.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode251
chrome/test/functional/translate.py:251: no_trans_url = 'http://www.google.com'
On 2010/08/04 20:45:18, Nirnimesh wrote:
> use a file:// url

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode252
chrome/test/functional/translate.py:252:
self._NavigateAndWaitForBar(self.spanish_google)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> use a file:// url from our corpus

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode258
chrome/test/functional/translate.py:258: self.assertFalse('translate_bar' in
translate_info)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> merge with last line
> self.assertFalse('translate_bar' in self.GetTranslateInfo())

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode264
chrome/test/functional/translate.py:264: self.assertTrue('translate_bar' in
translate_info)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> same here

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode267
chrome/test/functional/translate.py:267: """Tests that the translate bar
re-appears after forward navitation to a
On 2010/08/04 20:45:18, Nirnimesh wrote:
> merge this with the last test 

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode286
chrome/test/functional/translate.py:286: """Tests that translate bar is dimissee
if the page is crashed."""
On 2010/08/04 20:45:18, Nirnimesh wrote:
> s/dimissee/dismissed
> 
> s/page is crashed/renderer crashes/

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode288
chrome/test/functional/translate.py:288:
self._NavigateAndWaitForBar(self.spanish_google)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> use file:// url

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode294
chrome/test/functional/translate.py:294: self.assertFalse('translate_bar' in
translate_info)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> merge with last line

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode297
chrome/test/functional/translate.py:297: """Tests for the Prefs:Translate
option."""
On 2010/08/04 20:45:18, Nirnimesh wrote:
> remove 'for'

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode300
chrome/test/functional/translate.py:300: # Uncheck to translate.
On 2010/08/04 20:45:18, Nirnimesh wrote:
> remove 'to translate'

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode304
chrome/test/functional/translate.py:304: self.assertFalse('translate_bar' in
translate_info)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> merge with last line

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode310
chrome/test/functional/translate.py:310: self.assertFalse('translate_bar' in
translate_info)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> merge with last line 

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode313
chrome/test/functional/translate.py:313: """Verify translation works for all
sites in a translate corpora.
On 2010/08/04 20:45:18, Nirnimesh wrote:
> "Verify translation for several languages"

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode316
chrome/test/functional/translate.py:316: python translate.py
translate.TranslateTest.TranslateRunner -v
On 2010/08/04 20:45:18, Nirnimesh wrote:
> why not?

I didn't think we were checking the corpora in, so this test would fail if
anyone just checked out the code and ran all of the tests.

But now that all of the other tests depend on the corpora how will we handle
this?

http://codereview.chromium.org/3030042/diff/5001/6004#newcode323
chrome/test/functional/translate.py:323: corpora_path =
os.path.join(self.DataDir(), 'translate-sites')
On 2010/08/04 20:45:18, Nirnimesh wrote:
> let's name the dir 'translate'

Done.

http://codereview.chromium.org/3030042/diff/5001/6004#newcode324
chrome/test/functional/translate.py:324: corp_dir =
glob.glob(os.path.join(corpora_path, '*'))
On 2010/08/04 20:45:18, Nirnimesh wrote:
> (corpora_path, '??') will match only 2 letter names 

Some of the directories are 5 characters (ex. zh-CN). Is this okay?

http://codereview.chromium.org/3030042/diff/5001/6004#newcode332
chrome/test/functional/translate.py:332: logging.debug('Starting file %s' %
lang_file)
On 2010/08/04 20:45:18, Nirnimesh wrote:
> Isn't this portion the same as that for basic test?

Done.

http://codereview.chromium.org/3030042/diff/18001/3008#newcode70
chrome/test/functional/translate.py:70:
self.assertFalse(translate_info['page_translated'])
The translate bar seems to update its state a lot more reliably. I was getting
weird failures where the translate bar said AFTER_TRANSLATE but the page said it
hadn't been translated yet. Is it okay just to test based off of the bar here?

Nirnimesh

http://codereview.chromium.org/3030042/diff/5001/6004 File chrome/test/functional/translate.py (right): http://codereview.chromium.org/3030042/diff/5001/6004#newcode316 chrome/test/functional/translate.py:316: python translate.py translate.TranslateTest.TranslateRunner -v On 2010/08/04 23:32:07, Alyssa wrote: ...

10 years, 4 months ago (2010-08-04 23:39:40 UTC) #4

Alyssa

On 2010/08/04 23:39:40, Nirnimesh wrote: > http://codereview.chromium.org/3030042/diff/5001/6004 > File chrome/test/functional/translate.py (right): > > http://codereview.chromium.org/3030042/diff/5001/6004#newcode316 > ...

10 years, 4 months ago (2010-08-05 01:01:22 UTC) #5

LGTM. Thanks for all the weightlifting.

Expand Messages | Collapse Messages