Issue 3030026: Updated unicode library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3030026: Updated unicode library. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Updated unicode library. Added Nl category to letters predicate (as requried for JS identifiers). Changed/simplified representation of canonicalization ranges. Truncated tables to code points in the BMP (all that is used by JS). Reformatted tables to avoid excessively long lines. Removed duplicate entries from multi-character mapping result tables.

Patch Set 1 #

Patch Set 2 : Fixed lint-o. #

Patch Set 3 : Updated comment to match updated code. #

Patch Set 4 : Removed outdated comments. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1099 lines, -245 lines)			Patch
M	src/jsregexp.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/jsregexp.cc	View	1 2 3	4 chunks	+24 lines, -57 lines	0 comments	Download
M	src/unicode.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/unicode.cc	View	1	20 chunks	+1053 lines, -149 lines	0 comments	Download
M	src/unicode-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-regexp.cc	View		3 chunks	+20 lines, -37 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Feel free to ignore the actual table contents. There are tests to test that they ...

10 years, 4 months ago (2010-07-29 13:03:50 UTC) #1

LGTM

Expand Messages | Collapse Messages