New pyauto tests for clearing browsing data.

New pyauto tests for clearing browsing data.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53963

[Nirnimesh, 2010-07-27 22:43:47]

LGTM. nits only

http://codereview.chromium.org/3030022/diff/7001/8001
File chrome/test/functional/browsing_data.py (right):

http://codereview.chromium.org/3030022/diff/7001/8001#newcode17
chrome/test/functional/browsing_data.py:17: """Downloads the specified file and
waits for downloads to complete."""
Mention that it downloads from 'downloads' dir

http://codereview.chromium.org/3030022/diff/7001/8001#newcode28
chrome/test/functional/browsing_data.py:28: """Returns the url for the file if
the file is in the data directory."""
-> "Returns url for a file in the data dir."

The comment makes it sound as if you're checking if the file exsists.

http://codereview.chromium.org/3030022/diff/7001/8001#newcode51
chrome/test/functional/browsing_data.py:51: self.assertEqual(0,
len(cookie_data))
self.assertFalse(cookie_data)

http://codereview.chromium.org/3030022/diff/7001/8001#newcode61
chrome/test/functional/browsing_data.py:61: self.assertEqual(0, len(downloads))
same here

http://codereview.chromium.org/3030022/diff/7001/8001#newcode121
chrome/test/functional/browsing_data.py:121: self.assertEqual(0, len(history))
and here

[Alyssa, 2010-07-28 00:24:45]

http://codereview.chromium.org/3030022/diff/7001/8001
File chrome/test/functional/browsing_data.py (right):

http://codereview.chromium.org/3030022/diff/7001/8001#newcode17
chrome/test/functional/browsing_data.py:17: """Downloads the specified file and
waits for downloads to complete."""
On 2010/07/27 22:43:47, Nirnimesh wrote:
> Mention that it downloads from 'downloads' dir

Done.

http://codereview.chromium.org/3030022/diff/7001/8001#newcode51
chrome/test/functional/browsing_data.py:51: self.assertEqual(0,
len(cookie_data))
On 2010/07/27 22:43:47, Nirnimesh wrote:
> self.assertFalse(cookie_data)

Done.

http://codereview.chromium.org/3030022/diff/7001/8001#newcode61
chrome/test/functional/browsing_data.py:61: self.assertEqual(0, len(downloads))
On 2010/07/27 22:43:47, Nirnimesh wrote:
> same here

Done.

http://codereview.chromium.org/3030022/diff/7001/8001#newcode121
chrome/test/functional/browsing_data.py:121: self.assertEqual(0, len(history))
On 2010/07/27 22:43:47, Nirnimesh wrote:
> and here

Done.