Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 3030018: webkit_support: Move the logger initialization code so that it is... (Closed)

Created:
10 years, 5 months ago by tkent
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

webkit_support: Move the logger initialization code so that it is called after AtExitManager initialization, and call InitLogging() only if !unit_test_mode. InitLogging() needs AtExitManager because it uses PathService. TEST=This is a part of test code. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53743

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M webkit/support/webkit_support.cc View 3 chunks +44 lines, -44 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
10 years, 4 months ago (2010-07-26 12:33:27 UTC) #1
tony
10 years, 4 months ago (2010-07-26 17:04:59 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698