Issue 3030003: Mac: unit test for setting a clip rect with a scale transform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3030003: Mac: unit test for setting a clip rect with a scale transform (Closed)

Created:
10 years, 5 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
jeremy

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Mac: unit test for setting a clip rect with a scale transform BUG=none TEST=self Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52906

Patch Set 3 : '' #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -0 lines)			Patch
	A	skia/ext/bitmap_platform_device_mac_unittest.cc	View	1 2	1 chunk	+63 lines, -0 lines	2 comments	Download
	M	webkit/tools/test_shell/test_shell.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jeremy

LGTM http://codereview.chromium.org/3030003/diff/4001/5001 File skia/ext/bitmap_platform_device_mac_unittest.cc (right): http://codereview.chromium.org/3030003/diff/4001/5001#newcode19 skia/ext/bitmap_platform_device_mac_unittest.cc:19: BitmapPlatformDevice::Create(NULL, 400, 300, /*is_opaque=*/true)); Could you make the ...

10 years, 5 months ago (2010-07-18 11:24:06 UTC) #2

Nico

10 years, 5 months ago (2010-07-19 15:14:50 UTC) #3

Thanks, submitting

http://codereview.chromium.org/3030003/diff/4001/5001
File skia/ext/bitmap_platform_device_mac_unittest.cc (right):

http://codereview.chromium.org/3030003/diff/4001/5001#newcode19
skia/ext/bitmap_platform_device_mac_unittest.cc:19:
BitmapPlatformDevice::Create(NULL, 400, 300, /*is_opaque=*/true));
On 2010/07/18 11:24:07, jeremy wrote:
> Could you make the dimensions, constants

Done.

Expand Messages | Collapse Messages

Issue 3030003: Mac: unit test for setting a clip rect with a scale transform (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages