Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: base/environment.cc

Issue 3029062: base: rename Environment::GetEnv to Environment::GetVar. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/environment.h ('k') | base/environment_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/environment.cc
diff --git a/base/environment.cc b/base/environment.cc
index 6a6b556867992f44819667ed42ed6b13d74406ce..2f2431e6dd93af1843cc0688f02e056ed8fac5d4 100644
--- a/base/environment.cc
+++ b/base/environment.cc
@@ -21,8 +21,8 @@ namespace {
class EnvironmentImpl : public base::Environment {
public:
- virtual bool GetEnv(const char* variable_name, std::string* result) {
- if (GetEnvImpl(variable_name, result))
+ virtual bool GetVar(const char* variable_name, std::string* result) {
+ if (GetVarImpl(variable_name, result))
return true;
// Some commonly used variable names are uppercase while others
@@ -37,7 +37,7 @@ class EnvironmentImpl : public base::Environment {
alternate_case_var = StringToLowerASCII(std::string(variable_name));
else
return false;
- return GetEnvImpl(alternate_case_var.c_str(), result);
+ return GetVarImpl(alternate_case_var.c_str(), result);
}
virtual bool SetVar(const char* variable_name, const std::string& new_value) {
@@ -49,7 +49,7 @@ class EnvironmentImpl : public base::Environment {
}
private:
- bool GetEnvImpl(const char* variable_name, std::string* result) {
+ bool GetVarImpl(const char* variable_name, std::string* result) {
#if defined(OS_POSIX)
const char* env_value = getenv(variable_name);
if (!env_value)
@@ -120,7 +120,7 @@ Environment* Environment::Create() {
}
bool Environment::HasVar(const char* variable_name) {
- return GetEnv(variable_name, NULL);
+ return GetVar(variable_name, NULL);
}
} // namespace base
« no previous file with comments | « base/environment.h ('k') | base/environment_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698