Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 3029041: Mac: Keep groups when sorting task manager, like windows does. (Closed)

Created:
10 years, 4 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Mac: Keep groups when sorting task manager, like windows does. Also fix favicons in task manager. BUG=32148 TEST=Have a few tabs that share a process. Sort of various columns in the task manager, the process group should stay one block. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54206 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=54211 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54228

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : fix test? #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M chrome/browser/cocoa/task_manager_mac.mm View 1 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/task_manager_mac_unittest.mm View 3 3 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
didn't try this yet, still waiting for compile…
10 years, 4 months ago (2010-07-29 21:12:32 UTC) #1
viettrungluu
10 years, 4 months ago (2010-07-29 22:03:54 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698