Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: src/debug-debugger.js

Issue 3029033: Fix 'step in' after live edit stack manipulation (Closed)
Patch Set: follow codereview Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug.cc ('k') | src/ia32/debug-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2078 matching lines...) Expand 10 before | Expand all | Expand 10 after
2089 2089
2090 if (!IS_STRING(request.arguments.new_source)) { 2090 if (!IS_STRING(request.arguments.new_source)) {
2091 throw "new_source argument expected"; 2091 throw "new_source argument expected";
2092 } 2092 }
2093 2093
2094 var new_source = request.arguments.new_source; 2094 var new_source = request.arguments.new_source;
2095 2095
2096 var result_description = Debug.LiveEdit.SetScriptSource(the_script, 2096 var result_description = Debug.LiveEdit.SetScriptSource(the_script,
2097 new_source, preview_only, change_log); 2097 new_source, preview_only, change_log);
2098 response.body = {change_log: change_log, result: result_description}; 2098 response.body = {change_log: change_log, result: result_description};
2099
2100 if (!preview_only && !this.running_ && result_description.stack_modified) {
2101 response.body.stepin_recommended = true;
2102 }
2099 }; 2103 };
2100 2104
2101 2105
2102 // Check whether the previously processed command caused the VM to become 2106 // Check whether the previously processed command caused the VM to become
2103 // running. 2107 // running.
2104 DebugCommandProcessor.prototype.isRunning = function() { 2108 DebugCommandProcessor.prototype.isRunning = function() {
2105 return this.running_; 2109 return this.running_;
2106 } 2110 }
2107 2111
2108 2112
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
2218 case 'string': 2222 case 'string':
2219 case 'number': 2223 case 'number':
2220 json = value; 2224 json = value;
2221 break 2225 break
2222 2226
2223 default: 2227 default:
2224 json = null; 2228 json = null;
2225 } 2229 }
2226 return json; 2230 return json;
2227 } 2231 }
OLDNEW
« no previous file with comments | « src/debug.cc ('k') | src/ia32/debug-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698