Issue 3029032: Cleanup: Rename gtk button state names to (a) match other platforms and (b) n...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3029032: Cleanup: Rename gtk button state names to (a) match other platforms and (b) n... (Closed)

Created:
10 years, 4 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Rename gtk button state names to (a) match other platforms and (b) not be misleading (e.g. "depressed" where it should be "disabled"). Better indenting. Inline a function that has only one caller for simplicity. BUG=50107 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53741

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -84 lines)			Patch
M	chrome/browser/gtk/back_forward_button_gtk.cc	View		1 chunk	+11 lines, -13 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.h	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1	2 chunks	+10 lines, -23 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.h	View		4 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.cc	View		6 chunks	+33 lines, -23 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages