Download code cleanup:

Download code cleanup:

- make the code more object-oriented, make the object expose less accessors
- make some parts of code look more obvious, use existing helpers
- make the public interfaces slightly better (less ctor parameters)
- make some names slightly better

TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53808

[Paweł Hajdan Jr., 2010-07-23 23:45:44]

All feedback welcome. The goal is to make this code clear, so feel free to
comment what is not. Please note that I'm trying to make changes that in theory
should be safe.

[Paweł Hajdan Jr., 2010-07-24 00:23:56]

One more comment: the method names and comments are quite poor. It seems
difficult to me though to name and comment thing in the existing design, so I've
mostly preserved the existing method names and copied comments.

If some of these can be easily fixed, I'll be glad to do so.

[Paweł Hajdan Jr., 2010-07-26 21:37:24]

ping

[darin (slow to review), 2010-07-27 17:59:47]

LGTM

http://codereview.chromium.org/3029025/diff/4001/5004
File chrome/browser/download/download_item.cc (right):

http://codereview.chromium.org/3029025/diff/4001/5004#newcode182
chrome/browser/download/download_item.cc:182: // If we've received more data
than we were expecting (bad server info?), revert
nit: 80 char limit

http://codereview.chromium.org/3029025/diff/4001/5005
File chrome/browser/download/download_item.h (right):

http://codereview.chromium.org/3029025/diff/4001/5005#newcode83
chrome/browser/download/download_item.h:83: // Public API
this is sort of an odd comment to have in the "public:" section of the class
declaration :)