Issue 3029007: First step for cleaning registration code for ChromeFrame....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3029007: First step for cleaning registration code for ChromeFrame.... (Closed)

Created:
10 years, 5 months ago by stoyan

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

First step for cleaning registration code for ChromeFrame. Create separate RGS file for registering CLSID as a BHO. Remove the code that manually did the BHO registration. BUG=48987 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53040

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -61 lines)			Patch
M	chrome_frame/chrome_frame.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome_frame/chrome_tab.cc	View	1	4 chunks	+5 lines, -61 lines	0 comments	Download
A	chrome_frame/register_bho.rgs	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome_frame/resources/chrome_frame_resources.grd	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

ananta

10 years, 5 months ago (2010-07-19 21:12:42 UTC) #2

LGTM. Please change bho_bho.rgs to register_bho.rgs or something. Same change
for the constants.