Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 3029001: When I specified the rlz chrome extension api, I explicitly did not include a... (Closed)

Created:
10 years, 5 months ago by Roger Tawa OOO till Jul 10th
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

When I specified the rlz chrome extension api, I explicitly did not include a function to send pings to google for two reasons: - I thought that chrome's own rlz pings would send all rlz information for all other products installed on the machine - I did not want to allow an extension to DoS google by sending too many rlz pings It turns out that the rlz library itself makes sure that a given product's pings are never sent out more than once per day, as is required for rlz, so there is no DoS danger by exposing a ping function. Also, I was wrong in thinking that chrome's rlz pings would send out all rlz information about other products installed on the machine: it sends out the other products rlz strings, but it does not send out the other products rlz event information. This makes sense since there are signatures and brand codes and other information that cannot be determined by chrome for the extensions. So adding a new rlz chrome extension function to expose sending pings. BUG=None TEST=See particular extension using this api Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52800

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -0 lines) Patch
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_rlz_apitest.cc View 1 2 chunks +34 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_rlz_module.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_rlz_module.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/rlz/test.js View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Roger Tawa OOO till Jul 10th
10 years, 5 months ago (2010-07-15 17:35:52 UTC) #1
Aaron Boodman
lgtm
10 years, 5 months ago (2010-07-15 18:38:44 UTC) #2
Roger Tawa OOO till Jul 10th
Hi Aaron, The failure of the win try bot made me realize that I forgot ...
10 years, 5 months ago (2010-07-16 18:30:40 UTC) #3
Aaron Boodman
10 years, 5 months ago (2010-07-16 19:31:54 UTC) #4
still lgtm

Powered by Google App Engine
This is Rietveld 408576698